Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Feb. 23, 2012, 7:15 p.m., Cristian Oneț wrote: > > There are still some white space problems (spaces in empty lines - > > highlighted with red in the reviewboard diff) but ship it since it's > > already too big to follow. I've made a compilation and runtime test and it > > seems fine. Mak

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10847 --- Ship it! There are still some white space problems (spaces in

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/ --- (Updated Feb. 20, 2012, 5:37 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

Be aware that there is a second step that is run after the astyle command did its thing. The comment in astyle.sh says: # process the same set of files to replace "foreach(" with "foreach (" which is exactly what is done. Now if you run the script again, astyle changes "foreach (" into "foreach

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

On 27/01/12 06:08, Thomas Baumgart wrote: Hi, on Friday 27 January 2012 01:01:43 Allan Anderson wrote: On Jan. 26, 2012, 6:16 p.m., Cristian Oneț wrote: kmymoney/plugins/csvimport/convdate.cpp, line 47 What ha

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 6:17 p.m., Cristian Oneț wrote: > > Please revert all whitespace changes to their previous state which was in > > according to our coding style. Another reason to do that is that all those > > changes pollute the patch and make it hard to follow. > > Until then I'll test it

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

Hi, on Friday 27 January 2012 01:01:43 Allan Anderson wrote: > > On Jan. 26, 2012, 6:16 p.m., Cristian Oneț wrote: > > > kmymoney/plugins/csvimport/convdate.cpp, line 47 > > > > > ne47> > > > > > > What happened with t

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 6:17 p.m., Cristian Oneț wrote: > > Please revert all whitespace changes to their previous state which was in > > according to our coding style. Another reason to do that is that all those > > changes pollute the patch and make it hard to follow. > > Until then I'll test it

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 6:17 p.m., Cristian Oneț wrote: > > Please revert all whitespace changes to their previous state which was in > > according to our coding style. Another reason to do that is that all those > > changes pollute the patch and make it hard to follow. > > Until then I'll test it

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 6:16 p.m., Cristian Oneț wrote: > > kmymoney/plugins/csvimport/convdate.cpp, line 47 > > > > > > What happened with this file? > > All spaces between 'if' and '(' were removed. This is down t

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10101 --- These are the runtime issues I've found so far: 1. It's difficu

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10099 --- Please revert all whitespace changes to their previous state wh

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10098 --- kmymoney/plugins/csvimport/convdate.cpp

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/ --- (Updated Jan. 15, 2012, 1:09 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

On 21/12/11 20:49, Jack wrote: On 2011.12.21 15:39, Allan wrote: On 21/12/11 19:49, Jack wrote: On 2011.12.21 13:37, Allan Anderson wrote: ... That's the theory, anyway, but unfortunately, it's not always as straight forward as that. In general, though, banking files should be straight for

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

On 2011.12.21 15:39, Allan wrote: On 21/12/11 19:49, Jack wrote: On 2011.12.21 13:37, Allan Anderson wrote: ... That's the theory, anyway, but unfortunately, it's not always as straight forward as that. In general, though, banking files should be straight forward, but the 'last line' set

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/ --- (Updated Dec. 21, 2011, 8:47 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

On 21/12/11 19:49, Jack wrote: (To the list, not the review) On 2011.12.21 13:37, Allan Anderson wrote: ... That's the theory, anyway, but unfortunately, it's not always as straight forward as that. In general, though, banking files should be straight forward, but the 'last line' setting co

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

(To the list, not the review) On 2011.12.21 13:37, Allan Anderson wrote: ... That's the theory, anyway, but unfortunately, it's not always as straight forward as that. In general, though, banking files should be straight forward, but the 'last line' setting could cause a problem if the

[Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/ --- Review request for KMymoney. Description --- The intro wizard is chan