Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128878/ --- Review request for KMymoney. Repository: kmymoney Description ---

Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 73 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 16:19:41 + Build duration: 8 min 10 sec CHANGE SET Revision c0073108f83af30218a05a568c74c5efac207

Re: Review Request 128876: Handle CSV Importer exits the right way

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128876/ --- (Updated Sept. 10, 2016, 4:19 p.m.) Status -- This change has been m

Re: Review Request 128875: Add account autodetecting to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/ --- (Updated Sept. 10, 2016, 4:19 p.m.) Status -- This change has been m

[kmymoney4] [Bug 349139] Crash on CSVImport window close if CSVWizard window is gone

https://bugs.kde.org/show_bug.cgi?id=349139 NSLW changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 72 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 14:06:17 + Build duration: 8 min 15 sec CHANGE SET Revision 5b2dcc0ae9b0b7c8523772d4dd63fae051a92

Re: Review Request 128875: Add account autodetecting to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/#review99054 --- Ship it! Ship It! - Thomas Baumgart On Sept. 10, 2016,

Re: Review Request 128875: Add account autodetecting to CSV Importer

> On Wrz 10, 2016, 12:27 po południu, Thomas Baumgart wrote: > > I made the changes. Do you think it can be commited now? - Łukasz --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/

Re: Review Request 128875: Add account autodetecting to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/ --- (Updated Wrz 10, 2016, 3:05 po południu) Review request for KMymoney. R

Re: Review Request 128875: Add account autodetecting to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/#review99050 --- kmymoney/plugins/csvimport/csvwizard.cpp (line 529)

Re: Review Request 128876: Handle CSV Importer exits the right way

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128876/#review99049 --- Ship it! Ship It! - Thomas Baumgart On Sept. 10, 2016,

Review Request 128876: Handle CSV Importer exits the right way

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128876/ --- Review request for KMymoney. Repository: kmymoney Description ---

Jenkins-kde-ci: kmymoney master kf5-qt5 » Linux,gcc - Build # 71 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kmymoney%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 09:46:08 + Build duration: 8 min 11 sec CHANGE SET Revision f92a7c69d49b78ca72bce14d607e3505f4abf

Review Request 128875: Add account autodetecting to CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128875/ --- Review request for KMymoney. Repository: kmymoney Description ---

Re: Review Request 128817: Restructure pages in CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128817/ --- (Updated Sept. 10, 2016, 9:45 a.m.) Status -- This change has been m

Re: Review Request 128873: Add configuration dialog for CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128873/ --- (Updated Sept. 10, 2016, 11:45 a.m.) Status -- This change has been

Re: Review Request 128873: Add configuration dialog for CSV Importer

> On Wrz 10, 2016, 7:52 rano, Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/CMakeLists.txt, line 59 > > > > > > Please remove leftover whitespace char(s) > > Łukasz Wojniłowicz wrote: > It's done. Do

Re: Review Request 128873: Add configuration dialog for CSV Importer

> On Sept. 10, 2016, 7:52 vorm., Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/CMakeLists.txt, line 59 > > > > > > Please remove leftover whitespace char(s) > > Łukasz Wojniłowicz wrote: > It's done.

Re: Review Request 128874: Free QFileDialog memory

> On Wrz 10, 2016, 10:28 rano, Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/csvwizard.cpp, line 775 > > > > > > From the docs at http://doc.qt.io/qt-5/qlayout.html#addItem which is > > called by dialog-

Re: Review Request 128874: Free QFileDialog memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128874/#review99045 --- kmymoney/plugins/csvimport/csvwizard.cpp (line 775)

Re: Review Request 128873: Add configuration dialog for CSV Importer

> On Wrz 10, 2016, 7:52 rano, Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/CMakeLists.txt, line 59 > > > > > > Please remove leftover whitespace char(s) It's done. Do you see any other issues, that shoul

Re: Review Request 128873: Add configuration dialog for CSV Importer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128873/ --- (Updated Wrz 10, 2016, 10:05 rano) Review request for KMymoney. Reposit

Re: Review Request 128874: Free QFileDialog memory

> On Wrz 10, 2016, 8:03 rano, Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/csvwizard.cpp, line 769 > > > > > > Don't use dialog past this point w/o checking it for being unequal to > > 0. This is a very

Re: Review Request 128874: Free QFileDialog memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128874/ --- (Updated Wrz 10, 2016, 9:59 rano) Review request for KMymoney. Reposito