[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-22 Thread James Zhixin Zhang via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615 James Zhixin Zhang changed: What|Removed |Added CC||reachja...@reachjames.net --- Comment #1 f

Re: Review Request 128411: Integrate tableWidget into CSVWizard

2016-07-22 Thread Łukasz Wojniłowicz
> On July 20, 2016, 8:19 a.m., Thomas Baumgart wrote: > > I have done a visual inspection of the code parts. They look good to me. Good. Thanks for reviewing. Notable change that I made in actual commit is that I've moved updateWindowSize function to csvwizard.cpp (less code added in the end)

Re: Review Request 128470: Let Qt decide about CSVWizard size

2016-07-22 Thread Łukasz Wojniłowicz
> On July 20, 2016, 8:13 a.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvimport/csvwizard.cpp, line 62 > > > > > > Not sure if using KIconLoader is the way to go on KF5. Maybe one of our > > KF5 experts can