Re: [Kmymoney-devel] Review Request 119207: Refactor the contact fetching code into a single class.

2014-07-09 Thread Cristian Oneț
> On Iulie 10, 2014, 5:47 a.m., Marko Käning wrote: > > Hi Cristian, can you supply also a diff for branch frameworks, or is that > > still too early to ask for? Greets, Marko I posted this review request against master since I think that master should also contain this improvement. If it will

Re: [Kmymoney-devel] Review Request 119207: Refactor the contact fetching code into a single class.

2014-07-09 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119207/#review62037 --- Hi Cristian, can you supply also a diff for branch frameworks,

[Kmymoney-devel] Review Request 119207: Refactor the contact fetching code into a single class.

2014-07-09 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119207/ --- Review request for KMymoney. Repository: kmymoney Description ---

Re: [Kmymoney-devel] Review Request 119197: Add missing interdependency

2014-07-09 Thread Vadim Zhukov
2014-07-09 20:31 GMT+02:00, Thomas Baumgart : > Hi Vadim, > > maybe, the problem is already fixed with the add_dependencies statement > already present in the master branch and your addition is only needed in the > stable branch. Maybe, can't say for sure now. > So before I apply it, I let you in

Re: [Kmymoney-devel] Review Request 119197: Add missing interdependency

2014-07-09 Thread Thomas Baumgart
Hi Vadim, maybe, the problem is already fixed with the add_dependencies statement already present in the master branch and your addition is only needed in the stable branch. So before I apply it, I let you investigate this a bit more. When do you see the problem happening, because I have not se

Re: [Kmymoney-devel] Review Request 119197: Add missing interdependency

2014-07-09 Thread Vadim Zhukov
> On Июль 9, 2014, 7:18 п.п., Thomas Baumgart wrote: > > Does this solve the problem also? If you can confirm that, I am going to > > make the change. > > > > diff --git a/kmymoney/CMakeLists.txt b/kmymoney/CMakeLists.txt > > index acbc68d..12c8f50 100644 > > --- a/kmymoney/CMakeLists.txt > > +

Re: [Kmymoney-devel] Review Request 119197: Add missing interdependency

2014-07-09 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119197/#review61987 --- Does this solve the problem also? If you can confirm that, I a

[Kmymoney-devel] Review Request 119197: Add missing interdependency

2014-07-09 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119197/ --- Review request for KMymoney. Repository: kmymoney Description ---