Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Chris
Hi For what its worth I agree the patch is needed, as it stands the csv importer is unusable in windows and problematic in other distro's Chris On 18/04/2014 11:08 PM, Allan Anderson wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117620/

[Kmymoney-devel] Review Request 117630: Alkimia: Added a cmake package configuration file

2014-04-18 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117630/ --- Review request for KMymoney and Skrooge. Repository: alkimia Descriptio

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Allan Anderson
> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Cristian Oneț
> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Allan Anderson
> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Allan
On 18/04/14 01:15, Chris wrote: Ok I see at some stage in the recent past a patch was put in for the incorrect indexing of the cell which was causing the crashes if (ui->tableWidget->item(row, col) == 0) { // cell does not exist continue; } Chris No, not really. The

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Cristian Oneț
> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Cristian Oneț
> On April 18, 2014, 11:34 a.m., Allan Anderson wrote: > > Hi Cristian > > Many thanks. It had been starting to dawn on me that, when dealing with > > different distros, it shouldn't be necessary to fiddle about with margins > > to get things to look right. I'd suspected that I needed to make

Re: [Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

2014-04-18 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117620/#review56020 --- Hi Cristian Many thanks. It had been starting to dawn on me t

Re: [Kmymoney-devel] Validation feedback for complex input

2014-04-18 Thread Thomas Baumgart
Hi Christian, nice work. I would suggest the following (not knowing if it is too complex to implement though): a) for informational purposes (the white I on blue) I would use the tooltip variant. It's not really an error but contains additional information for the user she could get by opening