Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-01 Thread Thomas Baumgart
> On Jan. 2, 2014, 1:19 a.m., Allan Anderson wrote: > > I've noticed a potential problem. When making a multi-edit, the memo field > > appears cleared. If any other edit is made, and the edit is entered, the > > original memos are cleared too, which is undesirable. > > So, what I've done is r

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-01 Thread Allan Anderson
> On Jan. 1, 2014, 2:40 p.m., Thomas Baumgart wrote: > > kmymoney/dialogs/investtransactioneditor.cpp, line 1170 > > > > > > Isn't that simply > > > > if(memo) { > > d->m_activity->m_memoChanged =

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-01 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113427/#review46590 --- I've noticed a potential problem. When making a multi-edit, t

[Kmymoney-devel] [kmymoney4] [Bug 326683] 10-keypad's decimal separator not localized anymore

2014-01-01 Thread Mathieu MD
https://bugs.kde.org/show_bug.cgi?id=326683 --- Comment #6 from Mathieu MD --- Oh, and just for information, now xev output is: KeyPress event, serial 40, synthetic NO, window 0x4c1, root 0x2d6, subw 0x0, time 179075662, (-388,-124), root:(712,711), state 0x10, keycode 91 (keysym 0xf

[Kmymoney-devel] [kmymoney4] [Bug 326683] 10-keypad's decimal separator not localized anymore

2014-01-01 Thread Mathieu MD
https://bugs.kde.org/show_bug.cgi?id=326683 Mathieu MD changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Kmymoney-devel] [kmymoney4] [Bug 326683] 10-keypad's decimal separator not localized anymore

2014-01-01 Thread Mathieu MD
https://bugs.kde.org/show_bug.cgi?id=326683 --- Comment #4 from Mathieu MD --- Here is the output: KeyPress event, serial 40, synthetic NO, window 0x5e1, root 0x2d6, subw 0x0, time 177342530, (-352,-129), root:(748,706), state 0x10, keycode 91 (keysym 0x2e, period), same_screen YES,

[Kmymoney-devel] [kmymoney4] [Bug 326683] 10-keypad's decimal separator not localized anymore

2014-01-01 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=326683 --- Comment #3 from Thomas Baumgart --- Can you provide us with the event information for that key, please? Here's how to obtain that in case you don't know: 1. Start 'xev' in a console (that's where the output goes) 2. Hit the '.' on your decimal keyb

Re: [Kmymoney-devel] Review Request 114767: Add ability to modify loan institution attribute.

2014-01-01 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114767/#review46544 --- My initial comments after a quick walk-through. Looks good oth

[Kmymoney-devel] [kmymoney4] [Bug 307138] Add BTC (bitcoin.org) as supported currency.

2014-01-01 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=307138 Thomas Baumgart changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

Re: [Kmymoney-devel] Review Request 113427: Editing mulitple transactions - cannot change Memo field

2014-01-01 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113427/#review46543 --- Looks good to me to be shipped once my two remarks have been f