Re: [Kmymoney-devel] Calculation next check number

2012-01-26 Thread Cristian Oneț
2012/1/27 Thomas Baumgart : > Hi, > > on Thursday 26 January 2012 20:05:51 Cristian Oneț wrote: > >> On Thursday 26 January 2012 19:40:11 Hilarius Warwinkel wrote: >> > Is there a chance to see this in the 4.6.2 release next week ? >> >> It depends: >> 1. It still has to be reviewed/committed to ma

Re: [Kmymoney-devel] Calculation next check number

2012-01-26 Thread Thomas Baumgart
Hi, on Thursday 26 January 2012 20:05:51 Cristian Oneț wrote: > On Thursday 26 January 2012 19:40:11 Hilarius Warwinkel wrote: > > Is there a chance to see this in the 4.6.2 release next week ? > > It depends: > 1. It still has to be reviewed/committed to master I am trying to do that over the

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Thomas Baumgart
Hi, on Friday 27 January 2012 01:01:43 Allan Anderson wrote: > > On Jan. 26, 2012, 6:16 p.m., Cristian Oneț wrote: > > > kmymoney/plugins/csvimport/convdate.cpp, line 47 > > > > > ne47> > > > > > > What happened with t

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Cristian Oneț
> On Jan. 26, 2012, 6:17 p.m., Cristian Oneț wrote: > > Please revert all whitespace changes to their previous state which was in > > according to our coding style. Another reason to do that is that all those > > changes pollute the patch and make it hard to follow. > > Until then I'll test it

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Allan Anderson
> On Jan. 26, 2012, 6:17 p.m., Cristian Oneț wrote: > > Please revert all whitespace changes to their previous state which was in > > according to our coding style. Another reason to do that is that all those > > changes pollute the patch and make it hard to follow. > > Until then I'll test it

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Allan Anderson
> On Jan. 26, 2012, 6:16 p.m., Cristian Oneț wrote: > > kmymoney/plugins/csvimport/convdate.cpp, line 47 > > > > > > What happened with this file? > > All spaces between 'if' and '(' were removed. This is down t

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Allan Anderson
> On Jan. 26, 2012, 7:07 p.m., Cristian Oneț wrote: > > These are the runtime issues I've found so far: > > 1. It's difficult to figure out that you have to press enter to create the > > new profile for the first time > > 2. After I've created a profile I failed to create a second one > > 3. Whe

Re: [Kmymoney-devel] Calculation next check number

2012-01-26 Thread Cristian Oneț
On Thursday 26 January 2012 19:40:11 Hilarius Warwinkel wrote: > Is there a chance to see this in the 4.6.2 release next week ? > It depends: 1. It still has to be reviewed/committed to master 2. Is this a bugfix? (question towards the other devs) Regards, Cristian > On 18-01-12 06:53, Cristian

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10101 --- These are the runtime issues I've found so far: 1. It's difficu

Re: [Kmymoney-devel] Calculation next check number

2012-01-26 Thread Hilarius Warwinkel
Is there a chance to see this in the 4.6.2 release next week ? On 18-01-12 06:53, Cristian Onet, wrote: On Saturday 14 January 2012 18:22:07 Hilarius Warwinkel wrote: I'd like to post a patch for the calculation of the next check number in the Transaction Editor form. When you enter eg. "2012

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10099 --- Please revert all whitespace changes to their previous state wh

Re: [Kmymoney-devel] Review Request: Add profiles to csvplugin to retain user's settings

2012-01-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103492/#review10098 --- kmymoney/plugins/csvimport/convdate.cpp