kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
-Wvla: Warn because it's non-standard feature, not supported by MSVC to date
-Wdate-time: Warn because using __TIME
kfunk edited the summary of this revision.
kfunk edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5430
To: kfunk
Cc: #frameworks, #build_system
kfunk added a comment.
For -Wdate-time:
https://lxr.kde.org/search?_filestring=&_string=__DATE__
https://lxr.kde.org/search?_filestring=&_string=__TIME__
-> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The
use of __DATE__ & __TIME__ should just be avoided.
R
under both MinGW & MSVC.
Cheers,
Kevin
> Thanks in advance for your help
>
> Best regards
>
> --
> Matthieu Gallien
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
windows_fix
REVISION DETAIL
https://phabricator.kde.org/D5443
To: mgallien, kfunk, #windows
Cc: #frameworks
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
I'd say: Add a comment that this is for OS X/homebrew then it's okay as-is.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: k
kfunk updated this revision to Diff 13476.
kfunk added a comment.
Address mpyne's concerns
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13396&id=13476
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5430
AFFECTED FILE
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
+1
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5413
To: mgallien, kfunk
Cc: kfunk, heikobecker, dfaure, #frameworks
kfunk added a comment.
It's a "fix it, then ship it" like acceptance.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D5456
To: winterz, ltoscano, kfunk
Cc: kfunk, #frameworks, #documentation, skadinna
0;
-auto initializeImage = [=, &counter] (const QFileInfo& file) {
+auto initializeImage = [=, &counter] (const QFileInfo& file) -> Image {
auto const out = QFileInfo(outputDirectory,
file.fileName()).absoluteFilePath();
return Image(file.absoluteFilePath(
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0348332744d2: KDECompilerSettings: Pass -Wvla &
-Wdate-time (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13476&id=13554
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Fixes compiler warnings such as:
cl : Command line warning D9002 : ignoring unknown option
'-fsanitize=add
kfunk added reviewers: aacid, bcooksley.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5489
To: kfunk, aacid, bcooksley
Cc: #frameworks, #build_system
kfunk added inline comments.
INLINE COMMENTS
> kiconengine.cpp:87
>
> -if (!size.isValid()) {
> +if (!size.isValid() || size.height() == 0 || size.width() == 0) {
> return QPixmap();
`size.isEmpty()`?
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.or
20 16:03 GMT+05:00 Ben Cooksley :
> > Okay. Could you try building with these arguments to CMake and see what
> > happens?
> >
> > -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address'
> > -DBUILD_TESTING=ON
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for
e.g. MSVC (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5489?vs=13555&id=13
kfunk added inline comments.
INLINE COMMENTS
> ECMGeneratePkgConfigFile.cmake:172
>if(EGPF_INSTALL)
> -set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE
> PATH "The directory where pkgconfig will be installed to.")
> +if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Well, for me that looks good now
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #fr
kfunk added a comment.
What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5784
To: tcberner, #freebsd
Cc: kfunk, #frameworks
kfunk added a comment.
Okay, then maybe support for the current FreeBSD version is not implemented?
I have no idea about FreeBSD, to be honest. But it looks like using this API,
and implementing the proper support in `QStorageInfo` internals would be the
appropriate place.
Anyhow, if Qt
kfunk added a comment.
LGTM in general. I'll hope to find some time to test on Window, wouldn't want
this to be merged before that.
INLINE COMMENTS
> KDECompilerSettings.cmake:226
> +if (MSVC)
> +if (${MSVC_VERSION} GREATER 1900)
> +# /permissive- became the preferred
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
Can't go in as-is, as it breaks compilation on MSVC 2015.
But interesting to see that `/Za` is actually problematic. Which proves my
point: Just don't use named operators in cod
kfunk added a comment.
In https://phabricator.kde.org/D5865#112766, @rjvbb wrote:
> KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever,
right?
What non-sense is this? Please stay on topic. There's a benefit we make sure
KDE software is compiling under MSVC giv
kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> cfeck wrote in kfontrequester.cpp:187
> Does removing the default value mean the flags would be now uninitialized?
No, `QFontDialog::FontDialogOptions` is a `QFlags<>` wh
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
nonullptrforflagsplease
REVISION DETAIL
https://phabricator.kde.org/D6054
To: kossebau, #plasma, graesslin, kfunk
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
+1 on the behavior change, this is a much desired change :)
INLINE COMMENTS
> kateviewhelpers.cpp:204
> +if (m_leftMouseDown) {
> +int newVal = ((e->pos().y()-m_mapGroveRe
kfunk added subscribers: arrowdodger, kfunk.
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
I don't think we should do that. Compilation only breaks on MSVC2017, which
is fairly new. And according to some test compilations by @ar
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Also see: https://www.mail-archive.com/kde-windows@kde.org/msg07448.html
Error:
C:\JenkinsWS\workspace\Frameworks threadweaver kf5-
kfunk added reviewers: arrowdodger, bcooksley.
REPOSITORY
R279 ThreadWeaver
REVISION DETAIL
https://phabricator.kde.org/D6101
To: kfunk, arrowdodger, bcooksley
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R279:5973954f0b90: Work-around MSVC2017 compiler bug (authored
by kfunk).
REPOSITORY
R279 ThreadWeaver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6101?vs=15173&id=15184
REVISION DETAIL
h
kfunk added a comment.
+1 from my side -- Please wait for another +1 from another person.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6102
To: arrowdodger, #frameworks
Cc: kfunk
kfunk added a comment.
There are a couple of problems with the new behavior -- though I can't tell
precisely when they're caused. And not sure they're new or not either.
Things I'm seeing while mini map is enabled, only in some documents though:
- When the slider is position at the b
kfunk added a comment.
Works perfectly fine for me now, great! I don't see anything wrong with it
now from a behavioral point of view.
@dhaumann Maybe you want to check once more?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6086
To: sars, #ktexteditor, #
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CMake Warning (dev):
Policy CMP0058 is not set: Ninja requires custom command byproducts to be
explicit. Run "cmake --help-polic
kfunk updated this revision to Diff 15437.
kfunk added a comment.
Polishing
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6220?vs=15436&id=15437
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6220
AFFECTED FILES
data/CMakeL
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6253
To: tcberner, #freebsd, dfaure, kfunk
Cc: #frameworks
kfunk added reviewers: vkrause, dhaumann.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6220
To: kfunk, vkrause, dhaumann
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c70eb8b15640: CMake: Fix CMP0058 warning when using Ninja
(authored by kfunk).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6220?vs=15437&id=15726
RE
kfunk added a comment.
A couple of minor issues I spotted while looking briefly over the patch.
INLINE COMMENTS
> kateviewinternal.cpp:76
> +
> +bool detectZoomingEvent(QWheelEvent *e, Qt::KeyboardModifiers
> modifier=Qt::ControlModifier)
> +{
Style: Use ` = `
> kateviewinternal.cp
I've no incentive for getting this fixed, just wanted to add my 2c and
connect people.
Cheers,
Kevin
> I'll
> submit a patch for review that adds a runtime check of the widget style in
> use but if anyone has a better idea I wouldn't mind hearing it and avoiding
> unnecessary work.
>
> R.
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
kfunk created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Before:
Set Default Mark Type:
[ ] Bookmark
[X] Breakpoint
After:
Set Default Mark Type:
( ) Bookmark
kfunk updated this revision to Diff 16265.
kfunk added a comment.
Polish commit message
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6535?vs=16264&id=16265
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6535
AFFECTED FILES
src/view
kfunk edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6535
To: kfunk
Cc: kwrite-devel, #frameworks
kfunk updated this revision to Diff 16284.
kfunk added a comment.
Simplify code, address concerns
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6535?vs=16265&id=16284
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6535
AFFECTED FILES
kfunk updated this revision to Diff 16285.
kfunk added a comment.
Fix logic. Sorry, must have been asleep here... :\
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6535?vs=16284&id=16285
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D65
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6547
To: elvisangelaccio, #frameworks, kfunk
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:98aec940ec0b: Use mutually exclusive group in Default Mark
Type (authored by kfunk).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6535?vs=16285&id=16417
REVISI
kfunk added a comment.
Could you add a test in e.g. autotests/src/searchbar_test.cpp?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6473
To: jsalatas, #ktexteditor
Cc: kfunk, ltoscano, kwrite-devel, #frameworks
want when having used `KUrl::path()` before.
I've fixed `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` in Qt 5.6
to do what one would expect from it...
- Kevin Funk
On July 12, 2017, 6:10 a.m., Ralf Habacker wrote:
>
>
kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kaboutdata.cpp:352
> // Use normalized keywords, by the algorithm below.
> -static QHash ldict;
> -if (ldict.isEmpty()) {
> -ldict.insert("gpl", KAbou
> On July 12, 2017, 9:11 a.m., Kevin Funk wrote:
> > src/kdecore/kurl.h, line 437
> > <https://git.reviewboard.kde.org/r/130177/diff/1/?file=497118#file497118line437>
> >
> > Maybe it's also worth pointing people to
> > `QUrl::toDisplayString(QUrl
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
I can't reproduce the crash even without this patch anymore :\
I can't reproduce it *with* this patch either. The patch makes sense given my
backtrace in the bug report => ship it!
REPOS
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
LGTM
Other KF6-related notes in KF5 look the same.
REPOSITORY
R39 KTextEditor
BRANCH
addkf6todo
REVISION DETAIL
https://phabricator.kde.org/D6840
To: kossebau, #kate, kfunk
Cc: k
kfunk abandoned this revision.
kfunk added a comment.
Note: Abandoning this Diff in favor of the one from @emaurer
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5338
To: kfunk, dhaumann, kwrite-devel, vkrause
Cc: turbov, emaurer, #frameworks
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
removeUnusedFactoryInitDeclaration
REVISION DETAIL
https://phabricator.kde.org/D6782
To: kossebau, #frameworks, kfunk
kfunk added inline comments.
INLINE COMMENTS
> cfeck wrote in kpasswordlineedit.cpp:30
> That's fishy. I just checked a single class (KColumnResizer), and it has just
> "class KColumnResizerPrivate" (no namespace, no QObject), and still has a
> Q_PRIVATE_SLOT in its KColumnResizer class.
+1. D
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
TIL you can use `IMPORTED` on `add_executable`...
LGTM
REPOSITORY
R216 Syntax Highlighting
BRANCH
hl-cross-compile
REVISION DETAIL
https://phabricator.kde.org/D7102
To: vkrause,
kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:3
> +if(TARGET Qt5::Gui)
> +add_subdirectory(lib)
> +add_subdirectory(cli)
Too bad it needs QtGui. Just b/c it uses `QColor` as far as I can see...
kfunk added inline comments.
INLINE COMMENTS
> ktimecombobox.cpp:33
> +public:
> +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR);
> +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent
> = Q_NULLPTR);
Here and below: `nullptr` can be used directly i
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
I don't see why `find_file` would be needed here, yep.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
To: vkrause, #frameworks, kfunk
Cc: kfun
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R274 KIdleTime
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7156
To: asturmlechner, #frameworks, kfunk
Cc: #frameworks
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Use-case: Make building unit tests optional, by just following the CMake
BUILD_TESTING option.
The usual appro
kfunk updated this revision to Diff 17830.
kfunk added a comment.
Remove unrelated hunks
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17829&id=17830
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
AFFECTED FILES
kfunk added a comment.
It's not possible to easily disable tests at the moment, is it? I might be
missing something.
Anyhow, this patch tries to make it easy to build KDevelop without tests;
trying to avoid hacky approaches like those being done in Gentoo:
https://bugs.gentoo.org/
kfunk updated this revision to Diff 17835.
kfunk added a comment.
Fix typo. "no-top" is something else.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17830&id=17835
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
kfunk added a comment.
In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote:
> In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable
the target if `BUILD_TESTING` is false, why is that not enough?
Good question. I didn't explain that in the comm
kfunk accepted this revision.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
To: vkrause, #frameworks, kfunk
Cc: apol, kfunk
kfunk added a comment.
Guys... no one gave me an "Accepted' yet :)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
kfunk added a comment.
In https://phabricator.kde.org/D7187#133497, @kossebau wrote:
> +1 as well. Please also add a note in the API dox what BUILD_TESTING will
do on this macro, so this is not magic behaviour and people can plan with this
(like making sure to not set `target_link_librar
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7187?vs=17835&id=17858#toc
REPOSITORY
R240 Extra CMake Modules
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7213
To: asturmlechner, #frameworks, kfunk
Cc: kfunk
kfunk accepted this revision.
kfunk added a comment.
I like the initiative, +1
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk added a comment.
Other than that the patch looks sensible to me.
INLINE COMMENTS
> kateviewhelpers.cpp:2253
> +dMA =
> selectDefaultMark.addAction(m_doc->markDescription(markType));
> +} else {
> +mA = markMenu.addAction(icon,
> m_doc->markD
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ab503ec944fe: Fix compilation on windows with
editorconfig-c-core available (authored by kfunk).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7443?vs=18463&id=1
kfunk created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This also fixes an issue with regards to HAVE_FDATASYNC:
src/buffer/katesecuretextbuffer.cpp:157:5:
warning: 'HAVE_FDATASY
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0ee0be681108: Use config.h more (authored by kfunk).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7459?vs=18526&id=18529
REVISION DETAIL
https://phabricator.k
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Fixing an ancient porting bug which popped up when porting from Qt4 to
Qt5.
FIXED-IN: 5.38
BUG: 383843
REPOSITORY
R241 KIO
BRANCH
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:801f58e7e76a: Really rate-limit INF_PROCESSED_SIZE
messages (authored by kfunk).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7463?vs=18535&id=18541
REVISION DETAIL
kfunk added a comment.
In https://phabricator.kde.org/D7478#138855, @alexeymin wrote:
> Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ?
I think so.
FWIW: Here's another upstream report, filed by Heiko himself:
https://bugs.exim.org/show_bug.cgi?id=2158
REP
kfunk added a comment.
Just wanted to add this: Really great work! -- I wanted to raise this issue
earlier on the KF5 mailing list: ki18n was the last major framework that
depended on the deprecated QtScript. Nice to see it being ported! <3
Can't really review this code either, though. I
kfunk added a comment.
Could someone fluent in QtScript/QtQML review this so we can merge it?
INLINE COMMENTS
> ktranscript.cpp:96
> // Interface functions.
> -Q_INVOKABLE QScriptValue load(); // actually has variable length
> argument list
> -Q_INVOKABLE QScriptValue setcall(co
kfunk added a comment.
Could you add before/after screenshots for this?
I think this could also help non-RTL users understand what you're fixing.
Would be super helpful for me at least :)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7840
To: safaalfulaij,
kfunk added a comment.
Indeed, thanks for those fixes. /me can see a nice blog post coming a
long...? :)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7840
To: safaalfulaij, #ktexteditor, cullmann
Cc: cullmann, kfunk, #frameworks, sars, dhaumann
kfunk added a comment.
Screenshots please, for changes like this.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7884
To: helio, mwolff, kfunk
Cc: #frameworks, cullmann, sars, dhaumann
kfunk added a comment.
In https://phabricator.kde.org/D7884#147087, @sars wrote:
> I think "spaceWidth() / 2" goes a little bit too far.
I agree. The 'before' screenshot looks better in my eyes. The trailing mark
indicator is supposed to be a *subtle* hint, not something causing e
nsible, one could add more content to the build info
attribute which would be sent over to bugs.kde.org.
Regards,
Kevin
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Make sure links in dialogs point to https:// urls
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8209
AFFECTED FILES
make_kdepackages_updated.py
src/kaboutapplicat
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:3cc8b8f5ad26: Use https for KDE urls (authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8207?vs=20491&id=20502#toc
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
ht
kfunk added a comment.
In https://phabricator.kde.org/D8207#153510, @mpyne wrote:
> I support the idea, but I think there's a few more spots where we can
convert http:// to https://. I ran `ag --only-matching --no-heading
'http:.*k.*\.org'` in the kcoreaddons source directory, with the
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:1ee609564a8f: Use https for KDE urls (authored by kfunk).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8209?vs=20493&id=20504
REVISION DETAIL
https://phabricato
kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:23
> +if (CMAKE_CROSSCOMPILING)
> +set(GENERATE_ICONS_DEFAULT OFF)
> +else()
Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTIO
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
That comment could be a bit more verbose and better placed (i.e. move it next
to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along
"When cross-compiling qrcAlias wou
kfunk added a comment.
In KDevelop, this is also a really important shortcut for navigating through
the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to
declaration. /me wonders if one really needs a shortcut for configuring
shortcuts at all.
https://lxr.kde.org/sear
traight-forward and sustainable variant? I
thought this is working in general?
Why do we need diverge again (i.e. introducing a tool where no-one is familiar
with) instead of completing existing work?
Thanks,
Kevin
> Thank,
> René
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signa
On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote:
> Heya,
>
> The KDevelop team is currently discussing a patch which adds git-describe
> like information to the version string in KAboutData:
> https://phabricator.kde.org/D8158
> (don't bother readi
kfunk created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Warning:
/home/kfunk/devel/src/kf5/ktexteditor/src/dialogs/katedialogs.cpp:1455:11:
warning: 'runUrl' is deprecated [-Wdeprecat
301 - 400 of 530 matches
Mail list logo
