Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

ch as '#include ".moc"' from cpp files where it can, and includes '#include "moc_.cpp"' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/12

Re: Review Request 122105: Fix KgDifficulty saving on app close

onfig()` in order to make sure people don't do that? - Kevin Funk On Jan. 17, 2015, 9:48 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 122204: Mark results as required.

> On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > This change is not source-compatible though... 8-) or is it? > > Milian Wolff wrote: > It's _meant_ to be source-incompatible. All places where it doesn't > compile are "doing it wrong"™. > > If you mean abi-

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

thers giving their +1, too modules/ecm_uninstall.cmake.in <https://git.reviewboard.kde.org/r/122359/#comment52112> I'd remove the text inside the condition of `elseif`, `endif` and `endforeach` (I know it is copied code, but still ...) - Kevin Funk On Feb. 3, 2015, 8:19 p.m.,

Re: Review Request 122481: Fix use of environ for OS X

/qprocessenvironment.html#systemEnvironment` instead? Looks like you could get rid off the string conversion/parsing here. - Kevin Funk On Feb. 8, 2015, 10:06 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

> On Feb. 11, 2015, 3:35 p.m., Kevin Funk wrote: > > src/services/kplugininfo.cpp, line 574 > > <https://git.reviewboard.kde.org/r/122514/diff/1/?file=348194#file348194line574> > > > > Style: Space after keyword, more below. Wrong line, sorry. But

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

* good, though. src/services/kplugininfo.cpp <https://git.reviewboard.kde.org/r/122514/#comment52373> Style: Space after keyword, more below. - Kevin Funk On Feb. 10, 2015, 5:18 p.m., Aleix Pol Gonzalez wrote: > > ---

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75879 --- Ship it! LGTM. - Kevin Funk On Feb. 11, 2015, 5:45 p.m

Review Request 122539: Use Q_DECL_OVERRIDE where possible

1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

. Please tell me if it's desired and I'll go ahead. - Kevin Funk On Feb. 11, 2015, 11:19 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

/kconfigloader.h aadb19a5b266f4c1ccd07d4b05af0dcbd2686bd9 src/gui/kconfigloaderhandler_p.h 1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk

Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-framew

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75924 --- On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: > > --- > This is an aut

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

6393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mai

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

--- On Feb. 12, 2015, 3:47 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122542/ > --

Re: Review Request 122551: New feature: Open all recent files

) has session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened. - Kevin Funk On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote: > > --- > This is an

Re: OSX/CI: kde-baseapps fails to build for branch-group "stable-kf5-qt5"

quot;/Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFiles/ > CMakeOutput.log". > > KDE Continuous Integration Build > == Building Project: kde-baseapps - Branch Applications/14.12 > --- > > > Any idea what goes wrong? > > Regards, > Marko > ___

Re: OSX/CI: kde-baseapps fails to build for branch-group "stable-kf5-qt5"

On Friday 13 February 2015 21:56:42 Ben Cooksley wrote: > On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk wrote: > > On Friday 13 February 2015 08:49:10 Marko Käning wrote: > >> Hi Albert, > >> > >> I just realised that kde-baseapps fails on OSX/CI when being bui

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

eworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

boxtest.cpp <https://git.reviewboard.kde.org/r/122613/#comment52572> Just create on the stack? - Kevin Funk On Feb. 17, 2015, 10:29 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

tps://git.reviewboard.kde.org/r/123229/#comment53832> You could use http://doc.qt.io/qt-5/qcoreapplication.html#Q_COREAPP_STARTUP_FUNCTION + a queued method invocation to make sure `QApplication` was fully constructed. - Kevin Funk On April 7, 2015, 1:46 p.m., Aleix Pol Gonzalez

Re: Review Request 123452: Expose KJob::capabilities property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79421 --- Ship it! Ship It! - Kevin Funk On April 21, 2015, 4:24

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

tps://git.reviewboard.kde.org/r/123491/#comment54298> Rather: `${PRI_TARGET_BASENAME}_test.pro`? (Uses the correct suffix) - Kevin Funk On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote: > > --- > This is a

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

just spotted that the .pri file for SonnetUi doesn't have SonnetCore in its dependency list... => Bug? :) - Kevin Funk On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

g the right `QMAKEPATH` set during the test run imposes another burden on the user, however. What about adding: ``` set_tests_properties(... PROPERTIES ENVIRONMENT QMAKEPATH=${qt_host_data_dir} ``` - Kevin Funk On April 24, 2015, 3:26 p.m., Albert Astal

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180> > > > > Just tested the patch myself on sonnet. > > > >

Re: Versioning of Frameworks

's currently larger, but we should be > able to get it down to that): > > * PIM (not yet part of frameworks) > ** KCalendarCore > ** KCalendarUtils > ** KMIME > ** KIMAP > ** KContacts > > * Current Frameworks > ** ECM > ** KCoreAddons > ** KConfig &g

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180> > > > > Just tested the patch myself on sonnet. > > > >

Re: Versioning of Frameworks

On Wednesday, April 29, 2015 21:43:20 David Faure wrote: > On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: > > Use-case: Potential contributor working on KDevelop: > > - Has KF5 installed from distro packages > > - KDevelop/KDevPlatform compiled from Git > > - T

Install location of myframework_version.h headers

it? The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-fram

Re: Install location of myframework_version.h headers

On Monday, May 04, 2015 12:23:32 Kevin Funk wrote: > Heya, > > I'm wondering why, for instance, ktexteditor_version.h is installed to > $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. > > This currently leads to confusing behavior when trying to inclu

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 13:11:05 David Faure wrote: > On Monday 04 May 2015 12:29:39 David Faure wrote: > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > The issue could be easily fixed by moving the myframework_version.h into > > > $PREFIX/include/KF5/$FRAME

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 14:11:14 Kevin Funk wrote: > On Monday 04 May 2015 13:11:05 David Faure wrote: > > On Monday 04 May 2015 12:29:39 David Faure wrote: > > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > > The issue could be easily fixed by moving the myfr

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

mmary) find_package(ECM ...) set_target_properties(ECM ...) feature_summary(...) ... ``` I know that it is a bit harder to script this way , but helps code readability :D - Kevin Funk On May 13, 2015, 12:28 a.m., Jeremy Whiting

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 13, 2015, 6:45 a.m., Kevin Funk wrote: > > I'd reorder the code: > > > > ``` > > ... > > > > include(FeatureSummary) > > > > find_package(ECM ...) > > set_target_properties(ECM ...) > > feature_summary(...) > &g

Review Request 124542: CMake fixes for Windows build

he list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124542: CMake fixes for Windows build

ules", but CMake did not find one. ``` (I can also push this separately) - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 -------

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83249 --- On July 31, 2015, 7:34 a.m., Kevin Funk wrote: > >

Re: Review Request 124542: CMake fixes for Windows build

e3868fc4f22324d25f680c13609bfb92b8b7c41d Diff: https://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-

Review Request 124577: Fix Windows build

: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp 3e98befadb99dc81e65c7d0586f13bd1b375ad42 Diff: https://git.reviewboard.kde.org/r/124577/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 124577: Fix Windows build

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit a0fcb7d7ab14f379fabf440491ce40298ec0b540 by Kevin Funk to branch master. Repository: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp

Re: Review Request 124542: CMake fixes for Windows build

Diff: https://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-

Re: Review Request 124542: CMake fixes for Windows build

://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83574 --- @Luigi: Bump? - Kevin Funk On Aug. 6, 2015, 6:37 a.m

Re: Review Request 124542: CMake fixes for Windows build

marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 38265304276e6305f72a7e1a68aa1b4193657820 by Kevin Funk to branch master. Bugs: 348061 https://bugs.kde.org/show_bug.cgi?id=348061 Repository: kdoctools

Review Request 124696: Fix (worrying) MSVC warning

2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124696: Fix (worrying) MSVC warning

marked as submitted. Review request for KDE Frameworks and Mirko Boehm. Changes --- Submitted with commit ea52fb68bad35c91ed2cb39dc8cd0aeeea2f4f48 by Kevin Funk to branch master. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src

Minimum supported version of MSVC for frameworks

still broken) C++11 support anyway) Opinions? If you want, I can make sure KF5 builds on MSVC2013, at least, in irregular intervals. Cheers [1] https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 [2] https://paste.kde.org/pspfos96w -- Kevin Funk

Re: Minimum supported version of MSVC for frameworks

version to MSVC2013? I feel like people don't really want to revert the C++11 portions of code they've written until now anyway... Cheers, Kevin > Alex > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org

Review Request 124879: Optimization readEntryGui

: kconfig Description --- Don't attempt to build error string in any case Diffs - src/gui/kconfiggroupgui.cpp e2eb950fb93d40abec0988c9af58c1ae14cb2011 Diff: https://git.reviewboard.kde.org/r/124879/diff/ Testing --- Thanks, Kevin

Re: Review Request 124879: Optimization readEntryGui

, visit: https://git.reviewboard.kde.org/r/124879/#review84189 --- On Aug. 22, 2015, 5:11 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 124879: Optimization readEntryGui

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit a21e85d97f809870de94c84d2ca767260477f988 by Kevin Funk to branch master. Repository: kconfig Description --- Don't attempt to build error string in any case

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

p and running on Windows: - dbus-daemon - kded5 - kglobalaccel5 - kioslave - klauncher For the one-app use-case: Which ones do I need? How to stop them from being started? (Sorry, but I never really looked into that matter either, so any help welcome here). Given that KIO slaves can be invoked vi

Review Request 124896: Fix bad behavior / running OOM on Windows

ator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 Diff: https://git.reviewboard.kde.org/r/124896/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

27; to 'unsigned long', possible loss of data BUG: 345860 Diffs - src/kzoneallocator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 Diff: https://git.reviewboard.kde.org/r/124896/diff/ Testing --- Thanks, Kevin Funk ___ Kde-fr

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > Am 2015-08-24 01:03, schrieb Kevin Funk: > > Right now whenever I start kdevelop I get the following daemons up and > > running > > on Windows: > > - dbus-daemon > > - kded5 > > - kglob

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

started using KDevelop on Windows. Awesome! Thanks for this. - Kevin Funk On Aug. 24, 2015, 11:35 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

tps://git.reviewboard.kde.org/r/124902/#comment58353> Indeed. Just move into iface()? - Kevin Funk On Aug. 24, 2015, 11:35 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

xitcode= 0 exitStatus= 0 [5668] kf5.kservice.sycoca: Trying to open ksycoca from "C:/Users/kfunk/AppData/Local/cache/ksycoca5" ``` ^ Check says "ok" but then still - Kevin Funk On Aug. 22, 2015, 10:45 a.m., David Faure wrote: > >

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

> On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: > > Still runs kbuildsycoca5 for me(?) > > > > ``` > > [3796] kf5.kservice.sycoca: Trying to open ksycoca from > > "C:/Users/kfunk/AppData/Local/cache/ksycoca5" > > [3796] checking file ti

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

://127.0.0.1:56477") [6344] kf5.kinit.klauncher: "Z:/kderoot/bin/kioslave" (pid 4568) up and running. [4568] trying to load "Z:/kderoot/lib/plugins/kf5/kio/file.dll" from "Z:/kderoot/lib/plugins/kf5/kio/file.dll" ``` - Kevin Funk On Aug. 22, 2015, 10:45

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

> On Aug. 24, 2015, 12:15 p.m., Kevin Funk wrote: > > More context: > > > > ``` > > [5748] klauncher not running... launching kdeinit > > [6344] kf5.kinit.klauncher: LAUNCHER_OK > > [2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi > > [2892

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

> On Aug. 24, 2015, 11:52 a.m., Kevin Funk wrote: > > src/kglobalaccel.cpp, line 97 > > <https://git.reviewboard.kde.org/r/124902/diff/1/?file=397839#file397839line97> > > > > Indeed. Just move into iface()? > > Martin Gräßlin wrote:

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 05167e5bf563f3b9b2465e9da2ecf1e4a86a0d4d by Kevin Funk to branch master. Bugs: 345860 https://bugs.kde.org/show_bug.cgi?id=345860 Repository: kcompletion Description --- Fix bad

Review Request 124904: Make KDE_FORK_SLAVES work under Windows

. Repository: kio Description --- Make KDE_FORK_SLAVES work under Windows Diffs - src/core/slave.cpp 62455c1db471aa3fc1273b1bb398fbc183ddca1f Diff: https://git.reviewboard.kde.org/r/124904/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124905: Make KDE_FORK_SLAVES work under Windows

/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124905: Make KDE_FORK_SLAVES work under Windows

://git.reviewboard.kde.org/r/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc Diff: https://git.reviewboard.kde.org/r/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

marked as submitted. Review request for KDE Frameworks, David Faure and Boudewijn Rempt. Changes --- Submitted with commit a04683c12300c6b388fad2cfcd8e173d06ca5693 by Kevin Funk to branch master. Repository: kio Description --- Make KDE_FORK_SLAVES work under Windows Diffs

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

> > qEnvironmentVariableIsSet(). More efficient and easier to understand Done, see: commit 140a82d6796cb6ba82a9b173813968594113cb74 Author: Kevin Funk Date: Tue Aug 25 09:24:24 2015 +0200 Prefer qEnvironmentVariableIsSet - Kevin -

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

? - Kevin Funk On Aug. 24, 2015, 1:36 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

et when a target is created. http://www.cmake.org/cmake/help/v3.0/prop_tgt/WIN32_EXECUTABLE.html#prop_tgt:WIN32_EXECUTABLE - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.

Paths to internal executables (c.f. libexec) hard-coded

pplicationDirPath() via #ifdef Opinions? -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/m

Re: Paths to internal executables (c.f. libexec) hard-coded

On Wednesday 26 August 2015 13:40:20 Volker Krause wrote: > On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: > > Heya, > > > > This is problem on Windows because the *final* installation location is > > not > > known at compile-time (obviously software is in

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

s > > function is correct. > > > > Would we ever want a console window when running an app on windows? I guess > > not? > > So maybe we should do whatever "WIN32" does from within that function, if > > it's doable outside the add_executab

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

somebody working on these issues. - Kevin Funk On Oct. 29, 2015, 5:21 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126117: Fix resetting or changing the source model of a KRecursiveFilterProxyModel.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126117/#review88602 --- Ship it! Ship It! - Kevin Funk On Nov. 19, 2015, 1:33 p.m

Re: KApiDox Maintainship

n! Cheers, Kevin > Thanks Olivier! KApiDox does need that love! > And thanks Alex for the work so far! :) > > Aleix > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinf

Re: Review Request 128170: Allow nsspellcheck to be compiled on mac per default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128170/#review96431 --- Ship it! Rest LGTM - Kevin Funk On June 13, 2016, 7:43

Re: Review Request 128170: Allow nsspellcheck to be compiled on mac per default

tps://git.reviewboard.kde.org/r/128170/#comment65135> Nitpick: Excessive whitespace - Kevin Funk On June 13, 2016, 7:43 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128194: Mark helper exe as non-gui app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128194/#review96525 --- Ship it! Ship It! - Kevin Funk On June 15, 2016, 3:43

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

nFlags flags); ``` Makes the user code a bit easier to read. - Kevin Funk On June 19, 2016, 12:35 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96850 --- Cool, thanks Andreas! - Kevin Funk On June 24, 2016, 8:17

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

macro. Because macro uses > > `${ARGN}` it shouldn't break anything. > > Kevin Funk wrote: > @dfaure: Do you think this issue should be fixed in Qt itself? > > I've just found > http://stackoverflow.com/questions/33874243/qprocessstartdetached-but-h

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128650/#review98301 --- Rather port to `QRegularExpression` right away? - Kevin

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

on Windows (at least under MSVC). I'm not usually compiling kfilemetadata.git on Windows, so I wasn't affected by this change thus didn't notice. Can we make the dependency on xattr optional so we can restore the build with MSVC? - Kevin Funk On Feb. 26, 2016, 7:56 p.

Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

> On Aug. 14, 2016, 7:17 p.m., Thomas Pfeiffer wrote: > > Actually, this is in violation of the current search HIG ( > > https://community.kde.org/KDE_Visual_Design_Group/HIG/SearchPattern ), but > > since the de-facto standard in our software and elsewhere is an inline > > hint, I suppose we

Re: Review Request 128855: Fix build on Windows

? - Kevin Funk On Sept. 7, 2016, 3:23 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128855: Fix build on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/#review98993 --- Ship it! Ship It! - Kevin Funk On Sept. 7, 2016, 3:23

Re: C++11 & friends

nto nullptr, or > can we take the liberty and ditch Q_NULLPTR completely for all > frameworks? > > Same also applies to 'override'. > > Best, > Dominik -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: C++11 & friends

On Monday, 12 September 2016 09:10:46 CEST Jaroslaw Staniek wrote: > On 12 September 2016 at 08:04, Kevin Funk wrote: > > On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote: > > > Hi all, > > > > > > I just saw a commit by Volker tur

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129020/#review99522 --- Ship it! Ship It! - Kevin Funk On Sept. 26, 2016, 9:45

Re: Scrap baloo?

ment for a database backend. This is (sad) history repeating indeed. There are alternatives for the DB at least, which work, are maintained (by more than one person) and where using them won't put another burden on us KDE developers who are lacking manpower in all different areas already. > Actually, I don't insist on a tracker based solution, but I would like to > have some that doesn't end up in "KDE reinvents the wheel" once more if > there are perhaps alternatives available. As Christoph I don't care about a specific solution, but going the NIH route sounds, by far, like the worst option. I'm not questioning Boudhayan's credibility to work out a great "draft" implementation of a KVDB for academic research... But, the *major* selling points of database implementations is a track record of being rock-stable in different environments for a continuous amount of time. There's no way you can guarantee this for a one-man academic research project. Please reconsider the options. Just 2c of a worried user, fearing even more Plasma workspace instabilities... Kevin > Beside the speed argument, I got nothing that e.g. is a contra again using > tracker in this mail. > > (David had some good points in his mail, e.g. if sqlite doesn't have nfs > probs, yes, if locking is broken, or how to migrate the xattr data, which > is not solved yet) > > Greetings > Christoph -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Scrap Baloo Thread Feedback

likely makes sense for you to subscribe, no? Cheers, Kevin > (snip) -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. > > Hrvoje Senjan wrote: > The module is internal, so it intentionally doesn't install any cmake > files.

<    1   2   3   4   5   6   >