Re: Review Request 126161: OS X housekeeping

module doesn't exist, on Q_OS_OSX. The existing code to fallback to executing the binary directly will do exactly the same as your generic proxy, possibly even faster (no dlopen). - David Faure On Nov. 24, 2015, 11:03 p.m., René J.V. B

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Tuesday 24 November 2015 23:38:28 David Faure wrote: > On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: > > 2015-11-21 21:02 GMT-03:00 David Faure : > > > > > > This is an automatically generated e-mail. To reply, visit: > > > http

Re: Review Request 126164: Request proper dbus name for kioexec

runtime4 more precisely). This is a valid fix. We could also look at making kinit not require dbus registration from kioexec; usually kinit gets this information from the desktop file of the app, but for kioexec there's no desktop file, so it must be hardcoded somewhere. - David Faure On N

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 7:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > <https://git.reviewboard.kde.org/r/126161/diff/1/?file=418134#file418134line1621> > > > > Yes if you have to run a separate process which will then dlopen the > &g

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

en googling so I assumed it had been there for a very very long time, but maybe I'm wrong about that. In that case I'll revert that const stuff indeed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 7:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > <https://git.reviewboard.kde.org/r/126161/diff/1/?file=418134#file418134line1621> > > > > Yes if you have to run a separate process which will then dlopen the > &g

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

s zlib-devel-1.2.8, what's your zlib version? > > Mine is 1.2.3.4. OK, fix committed. http://commits.kde.org/karchive/e0875ab83a93f225c7af1285960017dd1933 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

Archive. autotests/kcompressiondevicetest.cpp (line 32) <https://git.reviewboard.kde.org/r/125941/#comment60878> not really needed for this QBuffer-based test, but ok, it's just a first step towards making QNetworkReply work, let's commit what works now. - David Faure On Nov. 25

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

ressiondevicetest.cpp (line 135) <https://git.reviewboard.kde.org/r/125941/#comment60882> #if HAVE_XZ_SUPPORT ... #else QSKIP("...") #endif - David Faure On Nov. 25, 2015, 9:19 p.m., Romário Rios wrote: > > ---

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

tps://git.reviewboard.kde.org/r/125941/#comment60884> Oh wow cmake integrates code for this based on libarchive, I didn't know that. I stand corrected. - David Faure On Nov. 25, 2015, 9:19 p.m., Romário Rios wrote: > > ---

Re: Failure while executing KTar::open while using KCompressionDevice as the device

b-encoded data. But I lost context of why we were talking about this. It's indeed different because it's not "KZip on top of a compressed QIODevice", that wouldn't make sense indeed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___

Re: Review Request 126161: OS X housekeeping

For the rest, using a helper does seem to give a better "emulation" of what > `kdeinit5` does on Linux, no? Not at all, kdeinit on linux does fork+dlopen, no exec. But my point is exactly that: if fork+dlopen is a problem on OSX, then don't do it, do fork+exec. T

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

on't see the purpose of the two new vars...) Wasn't only the last hunk of the patch that really made a difference? - David Faure On Nov. 9, 2015, 8:30 a.m., Emmanuel Pescosta wrote: > > --- > This is an automa

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

he "2 components" parts of it. www.mydomain.co.uk would lead to "co.uk" ? I'd suggest not limiting to two, it's unrelated to the bug you're fixing anyway - David Faure On Nov. 27, 2015, 11:14 p.m., Michael Pyne wrote: > > --

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

KE_EXE_LINKER_FLAGS or whatever. This for sure beats editing every link line, or trying to guess which frameworks are going to be "used by everyone". -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-fr

Re: Failure while executing KTar::open while using KCompressionDevice as the device

n 2 is nicer to app developers, but makes KArchive a bit too complex to my taste. Plus, one could argue that app developers are in a better position to decide whether a QBuffer is OK (reasonable size) or a temp file is necessary (huge files) ? -- David

Re: Review Request 126161: OS X housekeeping

one still has to open that dylib even when > exec'ing `kwrite` ... am I missing something? Yes but I bet it means some symbol lookups happen at runtime rather than at link time. I'm not enough of a lowlevel mac toolchain expert to give a fully satisfying explanation, but I'm not

Re: Review Request 126161: OS X housekeeping

s that I should look up the caller path to > see where kdeinit verifies if there is a kdeinit module for the tool it has > been requested to start, and disable that part? Yes - which is exactly what my suggested patch does, AFAICS. -- David Faure, fa...@

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126189/#review89020 --- Ship it! Ship It! - David Faure On Dec. 2, 2015, 3:51 a.m

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

, though. (cookie dialog, SSL cert messagebox + dialog, etc. etc.). If making it an "agent" doesn't prevent it from showing GUI elements now and then, then no problem. - David Faure On Nov. 25, 2015, 6:12 p.m., René J.

Re: Review Request 126149: [Icon widget] Bring back properties dialog

. applets/icon/plugin/icon_p.cpp (line 239) <https://git.reviewboard.kde.org/r/126149/#comment60951> why commented out? - David Faure On Nov. 26, 2015, 8:15 p.m., Kai Uwe Broulik wrote: > > --- >

Re: Updating techbase wiki page according to KF5 policies

class that it defines. > is only > possible by fluke, really, as a side effect of where we install the > version headers. Well it's the same as , i.e. an include that starts with the module name. But for the same reasons as in Qt, this is not recommended. -- David Faure,

Re: Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes

there are still people using this dialog though, I was considering removing it :-). The default settings (for many years) are to not show this dialog, I assume you change the settings so that it is shown? - David Faure On Dec. 4, 2015, 5:16 p.m., Jonathan Marten

Re: KNotifications filters

nfig can go into a framework-specific config file, it doesn't have to be kdeglobals. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail

Re: Review Request 125762: External extractor plugin support for KFileMetaData

#comment61012> const QString &extractor src/extractors/externalextractor.cpp (line 94) <https://git.reviewboard.kde.org/r/125762/#comment61011> maybe with a timeout? + error handling? - David Faure On Oct. 24, 2

Re: Review Request 125800: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125800/#review89165 --- Ship it! Ship It! - David Faure On Oct. 27, 2015, 11:01

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

> On Nov. 2, 2015, 8:08 a.m., David Faure wrote: > > Ah I see, forget what I said about HTTP proxy. > > > > About the missing argument, it would indeed be useful for this code: > > http://lxr.kde.org/source/extragear/network/konversation/src/irc/server.cpp > &

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

match my expectations of the QUrl behaviour: QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than file:///tmp/. I consider this a bug (when NormalizePathSegments isn't set), I'll discuss it with Thiago and possibly fix it in Qt. - David Faure On Nov. 28,

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 6, 2015, 11:19 a.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than >

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 6, 2015, 11:19 a.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than >

Re: Review Request 126038: Add protocol info to KIO plugin metadata

> On Nov. 12, 2015, 4:12 p.m., Christoph Cullmann wrote: > > Hi, > > > > I did the same in https://git.reviewboard.kde.org/r/125869/ but I still > > need to fix the i18n issue, first :/ > > Andrew McCann wrote: > Ahh, indeed you did. > > Should I abandon this? or do I 'add' it to

Re: about QSP::RuntimeLocation and XDG_RUNTIME_DIR on OS X/MacPorts

io_http_cache_cleaner. As I suspected, none of this needs interoperability with the rest of the XDG world. So it doesn't matter where these sockets are put on Mac OS X, as long as the security requirements are met. Therefore "~/Library/Application Support" seems fine to me. -- D

Re: OS X : org.kde.klauncher5 was not provided by any .service files

5 on startup, and then klauncher5 registers to DBus. Ignore the mention of ".service files" that's DBus' way of saying "this process is not running, so I tried to autostart it and didn't find how to". But in this case, we don't use autostart, so the p

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showi

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

tps://git.reviewboard.kde.org/r/126184/#comment61017> this code path didn't call accept() before. Please investigate when save can fail, or keep former behaviour (by adding "return;"). - David Faure On Nov. 27, 2015, 1:40 p.m., Jean-Ba

Re: kpty/utempter

tion is, how useful is this in KPty? `utempter is a privileged helper program that writes utmp/wtmp entries for unprivileged programs.` Does utmp or wtmp exist on OSX? Hmm, yes, but deprecated -- https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man5/utmp.5.html So prob

Re: kpty/utempter

On Sunday 06 December 2015 22:00:09 René J.V. Bertin wrote: > On Sunday December 06 2015 21:52:21 David Faure wrote: > > > > Question is, how useful is this in KPty? > > > > `utempter is a privileged helper program that writes utmp/wtmp entries for > > unpriv

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Sunday 06 December 2015 21:55:44 René J.V. Bertin wrote: > On Sunday December 06 2015 14:51:40 David Faure wrote: > > > Here is an easy way to test this: do the same change for kiod in kio (it's > > like a mini kded) and then > > cd kio/tests ; ./listjobt

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

pplication constructor. But I don't understand what was the problem with the function being called even earlier. Do we have a case where a kio job is created before the app is constructed? (that sounds wrong). - David Faure On Dec. 7, 2015, 1:29 p.m., Aleix Pol

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

> On April 7, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > > > > > This is not correct, it's too early to figure out if it's going to have > > a QApplication or not.

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

File) only at the time of displaying this to the user. retrievePlacePath() doing idx+=3 and url.left(idx) is indeed very very wrong, in terms of path escaping. - David Faure On Dec. 9, 2015, 9:42 p.m., Xuetian Weng wrote: > > ---

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

r/123229/#comment61065> this check should also be done on line 76 where another KWidgetJobTracker is being created, then. - David Faure On Dec. 7, 2015, 1:29 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatica

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

f (placeUrl.isLocalFile()) { dirName = QStringLiteral("/"); } else { dirName = placeUrl.toDisplayString(); } no? src/filewidgets/kurlnavigator.cpp (line 784) <https://git.reviewboard.kde.org/r/126295/#comment61134> setPath(QSt

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Monday 07 December 2015 16:14:54 René J.V. Bertin wrote: > On Sunday December 06 2015 14:51:40 David Faure wrote: > > > Here is an easy way to test this: do the same change for kiod in kio (it's > > like a mini kded) and then > > cd kio/tests ; ./listjobt

Re: kdelibs4support forces "icons in buttons"?

o hard feelings, just that everything has a right place. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

5.6 is out, wrap your fix with #if QT_VERSION < QT_VERSION_CHECK(5, 6, 0). We can always clean it up once 5.6 is required (i.e. in a few years ;). And mention the qt fix in a comment of course. I don't mind which way around you choose to go. - David Faure On Nov. 28, 2015, 9:36 p.m.,

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

uess the theme factory in Qt will then randomly pick one of the two plugins providing the key "KDE" ? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

buttons and check their number and the text on each one. src/filewidgets/kurlnavigator.cpp (line 371) <https://git.reviewboard.kde.org/r/126295/#comment61153> No need for PreferLocalFile anymore, the url is always remote. My code was correct :) - David Faure On Dec. 12, 2015, 11:

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 12, 2015, 11:12 a.m., David Faure wrote: > > Either that, or if you want the fix to be available before 5.6 is out, wrap > > your fix with #if QT_VERSION < QT_VERSION_CHECK(5, 6, 0). > > > > We can always clean it up once 5.6 is required (i.e. in a few

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

. http://www.davidfaure.fr/2015/0001-Add-autocompletion-for-.-input-which-offers-all-hidd.patch ok with you? - David Faure On Nov. 28, 2015, 9:36 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

tps://git.reviewboard.kde.org/r/126329/#comment61183> the extra spaces before the ')'s don't make sense anymore (I guess they were for alignment) - David Faure On Dec. 12, 2015, 11:08 p.m., Patrick Spendrin wrote: > > -

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/#review89450 --- Ship it! Ship It! - David Faure On Dec. 13, 2015, 10:04

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126312/#review89451 --- Ship it! Ship It! - David Faure On Dec. 14, 2015, 7:08

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/#review89580 --- Ship it! Ship It! - David Faure On Dec. 14, 2015, 10:37

Re: Review Request 126330: use Qt defines for portability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/#review89581 --- I vote for generate_export_header. - David Faure On Dec

Re: about ki18n/locales: installing only a subset?

quot;; binning the unwanted files before building... Yep, remove them if you don't want them, but then your users are going to complain, unless you provide them separately. The overhead is minimal and allows for modularity. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

VERSION 6) ../networkmanager-qt/CMakeLists.txt:40:SOVERSION 6) > PS : KDE4's kfilemetadata has a compatibility/so version 4 ... Doesn't matter, it had a different library name (no KF5 in the name). -- David Faure, fa...@kde.org, http://w

Re: Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126326/#review89582 --- Ship it! Ship It! - David Faure On Dec. 12, 2015, 10:58

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126325/#review89583 --- Ship it! Ship It! - David Faure On Dec. 13, 2015, 10:38

Re: about ki18n/locales: installing only a subset?

On Wednesday 16 December 2015 11:20:38 René J.V. Bertin wrote: > On Wednesday December 16 2015 09:03:53 David Faure wrote: > > > Yep, remove them if you don't want them, but then your users are going to > > complain, unless you provide them separately. > > I t

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

call QStyle's CE_PushButton, so I don't see why these two would be working differently. Is this a workaround for KPushButton which doesn't fix QPushButton? - David Faure On Dec. 11, 2015, 4:26 p.m., René J.V. Bertin wrote: > > -

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Wednesday 16 December 2015 17:42:29 šumski wrote: > On Wednesday 16 of December 2015 09:08:03 David Faure wrote: > > Fixed, it was an oversight when converting the lib into a KF5 framework. > > But this is a BiC change... One that is generally allowed (not like removing a vir

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

usly for that session, > rather than the geometry used by whatever KDevelop session was run last. On > OS X that would be done with something like `[NSWindow > setFrameautosaveName:[window representedFile]]`, where `[NSWindow > representedFile]` corresponds to `QWindow::filePath`

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

usly for that session, > rather than the geometry used by whatever KDevelop session was run last. On > OS X that would be done with something like `[NSWindow > setFrameautosaveName:[window representedFile]]`, where `[NSWindow > representedFile]` corresponds to `QWindow::filePath`

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90085 --- Ship it! Ship It! - David Faure On Dec. 25, 2015, 12:12

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126506/ > --- > > (Updated Dec. 25, 2015, 12:12 a.m.) > > &g

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

> On Dec. 25, 2015, 9:14 a.m., David Faure wrote: > > Ship It! withdrawn, see above - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#re

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showi

Re: Splitting KActivities, 2nd attempt...

tegration or solution, all > OSs) > - kactivitymanagerd (service, kcm settings module, dolphin plugin; > officially linux-only) Shouldn't the service be part of the framework? How usable is the framework without the service? Compiling is good, but running is even better :-) -- David

Re: Review Request 126149: [Icon widget] Bring back properties dialog

> On Dec. 29, 2015, 6:07 p.m., Kai Uwe Broulik wrote: > > I completely screwed up my Kate desktop files :( Would it help if I set > > NoDisplay or Hidden on the desktop file copy so it's there for the icon > > widget but not shown in the Open With dialogs and so on? Or, if I copied > > the des

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

apps are using kDebug less and less. Is it worth risking compilation breakages on some systems? Also I found kBacktrace less and less useful over the years because with hidden visibility I get a lot of "???" for non-exported methods. gdb works much better. - David Faure On Dec. 10

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/#review90393 --- Ship it! Ship It! - David Faure On Dec. 11, 2015, 2:08

Re: Review Request 126385: PartManager: stop tracking a widget even if it is no longer a top level window

the commit log: "since all signal connections to 'this' are removed on destruction anyway". They are indeed, but *after* destroyed is emitted. So disconnecting does make a difference. - David Faure On Dec. 16, 2015, 1:

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 3:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace le

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/#review90400 --- Ship it! Ship It! - David Faure On Dec. 24, 2015, 5:55

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/#review90401 --- Ship it! Ship It! - David Faure On Dec. 23, 2015, 7:50

Re: Review Request 126453: Fix library order

tters here (or what the right order would be). It all depends on what you have in /usr/include. But ok. - David Faure On Dec. 21, 2015, 4:06 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

k it's just an omission in the doc, the whole point of the QRegularExpression API is thread safety. - David Faure On Dec. 28, 2015, 2:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To re

Re: KHolidays as Framework (redux)

o be included as > a Tier 1 Framework in the next possible release. What's the next step? Please make sure it passes all of the items in this checklist https://community.kde.org/Frameworks/CreationGuidelines -- David Faure, fa...@kde.org, http://www.davidfaure.fr

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

tps://git.reviewboard.kde.org/r/126507/#comment61842> this condition used to be evaluated when tiles was non-null (i.e. key in cache). In your patch, key-in-cache goes to the very first branch and not here anymore. - David Faure On Dec. 25, 2015, 12:16 a.m., Michael Pyne

Re: Splitting KActivities, 2nd attempt...

On Friday 01 January 2016 18:07:59 Ivan Čukić wrote: > > So, applications that do link to activities will run and work > uninterrupted even if the service is not present. OK, sounds good to me. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Fra

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

> On Jan. 1, 2016, 5:15 p.m., David Faure wrote: > > src/urifilters/shorturi/kshorturifilter.cpp, line 58 > > <https://git.reviewboard.kde.org/r/126474/diff/2/?file=426362#file426362line58> > > > > "despite" sounds like the api docs say that it&#x

Re: Review Request 126403: Get rid of QApplication dependency

hen at least something like QRect(QPoint(0,0), displayGeometry().size()) (encapsulated in a convenience function) would avoid calling displayGeometry() twice. - David Faure On Dec. 17, 2015, 3:38 p.m., Thomas Lübking wrote: > > -

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

ull pointer anyway. But K4Style runs in the GUI thread always anyway. So I would call object(), put that into a pointer, and then if not null, make a copy into a value. This avoids the double lookup. - David Faure On Jan. 2, 2016, 1:55 a.m., Michael

Re: Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/#review90441 --- Ship it! Ship It! - David Faure On Dec. 27, 2015, 2:40

Re: Review Request 126161: OS X housekeeping

> On Dec. 25, 2015, 2:42 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit_mac.mm, lines 662-666 > > > > > > I'd love to add `[NSApp activateIgnoringOtherApps:YES]` and/or `[NSApp > > unhide]` here, preceded b

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showi

Re: Review Request 126314: Port klauncher to xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126314/#review90445 --- Ship it! Ship It! - David Faure On Dec. 11, 2015, 3:10

Re: closest equivalent to KApplicationPrivate::init() ?

ion. Apps started while the user is typing elsewhere shouldn't be brought to the foreground. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showi

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 13:46:17 René J.V. Bertin wrote: > On Saturday January 02 2016 12:50:59 David Faure wrote: > > > > I added a "bring application to the foreground" call (to a KWindowSystem > > > helper function) in there, which alleviated the issu

test failures on http://ci-logs.kde.flaska.net

front (so it's viewed as being "on top of" the kde mimetype file, while it's supposed to be the other way around). Can this be fixed in the CI setup? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 _

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 15:59:04 René J.V. Bertin wrote: > On Saturday January 02 2016 14:14:19 David Faure wrote: > >Maybe, maybe not, but what we need to continue this discussion is hard data. > >1) what does QProcess on Mac do (always in front, always in background, > &

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/#review90467 --- Ship it! Ship It! - David Faure On Jan. 2, 2016, 4:02 p.m

Re: Review Request 126028: Add support for desktopFileName to NETWinInfo

version needs to be updated (to 5.19 actually, since I just tagged 5.18). Unless you shout quickly for a 5.18 respin. - David Faure On Nov. 11, 2015, 1:15 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e

Re: closest equivalent to KApplicationPrivate::init() ?

switch to LaunchServices rather than using standard > Posix APIs? Those are implementation details. IMHO the API shouldn't talk about any of that, but rather have a flag like "it's a GUI app that I'm starting", which would hint at using LaunchServices on OSX is that'

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

particular line. - David Faure On Jan. 3, 2016, 9:09 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos >

Re: Review Request 126505: Do not show a warning color before the user even started typing

> On Jan. 2, 2016, 11:33 a.m., David Faure wrote: > > Ship It! > > Elvis Angelaccio wrote: > Uhmm, the new tests don't pass locally on my system. I'm fairly sure it's > because I have kwidgetsaddons 5.17 globally installed from archlinux repos >

  1   2   3   4   5   6   7   8   9   10   >