Giorgos Tsiapaliwkas wrote:
> On 11 April 2012 14:55, Stephen Kelly wrote:
>>
>> It's not clear which patch you're talking about. As far as I can see, you
>> didn't really post the patches individually, but just posted the moevs
>> that you made along with the CMakeLists changes you made (as one
On 11 April 2012 14:55, Stephen Kelly wrote:
>
> It's not clear which patch you're talking about. As far as I can see, you
> didn't really post the patches individually, but just posted the moevs that
> you made along with the CMakeLists changes you made (as one patch).
>
yes it is one patch beca
Giorgos Tsiapaliwkas wrote:
> On 11 April 2012 00:54, David Faure wrote:
>>
>> Is this a patch for 'frameworks' or for 'frameworks-kcolors'?
>>
>
> which one? the sonnet one? All of them are for the kwidgets branch.
It's not clear which patch you're talking about. As far as I can see, you
did
On 11 April 2012 00:54, David Faure wrote:
>
> Is this a patch for 'frameworks' or for 'frameworks-kcolors'?
>
which one? the sonnet one? All of them are for the kwidgets branch.
I can make the move in the frameworks(of course a review first), but then I
will need the change.
> Per Steve's las
On Sunday 08 April 2012 21:25:51 Giorgos Tsiapaliwkas wrote:
> Hello,
>
> I moved kcursor and also I moved the sonnet ui stuff into
> staging/sonnet/src/ui
Is this a patch for 'frameworks' or for 'frameworks-kcolors'?
Did you see the discussions and the backports into frameworks?
Any chance you
Hello,
I moved kcursor and also I moved the sonnet ui stuff into
staging/sonnet/src/ui
my 2 commits
# renamed:kdeui/findreplace/kfind.cpp ->
staging/kwidgets/src/findreplace/kfind.cpp
# renamed:kdeui/findreplace/kfind.h ->
staging/kwidgets/src/findreplace/kfind.h
# r
On Tuesday 03 April 2012 15:00:58 Giorgos Tsiapaliwkas wrote:
> Hello,
>
> sorry for the delay
>
> On 28 March 2012 18:11, David Faure wrote:
> > Yes -- assuming libkwidgets still compiles, but I'll be checking that
> > after
> > you push the commits anyway :-)
> >
> > Thanks!
>
> libkwidgets
Hello,
sorry for the delay
On 28 March 2012 18:11, David Faure wrote:
>
> Yes -- assuming libkwidgets still compiles, but I'll be checking that after
> you push the commits anyway :-)
>
> Thanks!
libkwidgets doesn't compile due to undefined references. (I have attached
the error).
What should
On Wednesday 28 March 2012 16:14:32 Giorgos Tsiapaliwkas wrote:
> Hello,
>
> patch 1
>
> # renamed:kdeui/dialogs/kmessagebox.cpp ->
> staging/kwidgets/src/dialogs/kmessagebox.cpp
> # renamed:kdeui/dialogs/kmessagebox.h ->
> staging/kwidgets/src/dialogs/kmessagebox.h
> #
Hello,
patch 1
# renamed:kdeui/dialogs/kmessagebox.cpp ->
staging/kwidgets/src/dialogs/kmessagebox.cpp
# renamed:kdeui/dialogs/kmessagebox.h ->
staging/kwidgets/src/dialogs/kmessagebox.h
# renamed:kdeui/widgets/kcombobox.cpp ->
staging/kwidgets/src/widgets/kcombobox.
On Tuesday 27 March 2012 18:50:30 Giorgos Tsiapaliwkas wrote:
> # renamed:kdeui/itemviews/klistwidget.cpp ->
> staging/kwidgets/src/itemviews/klistwidget.cpp
The plan for that one was to get rid of it (-> kde4support).
It's really just a QListWidget with some file-management features (l
Hello,
today with dfaure we solved a few more errors, but we had to split some
more widgets.
So these are my patches,
commit 1:
#
# renamed:kdeui/dialogs/kmessagebox.cpp ->
staging/kwidgets/src/dialogs/kmessagebox.cpp
# renamed:kdeui/dialogs/kmessagebox.h ->
staging/kwidgets/
On Friday 16 March 2012 00:01:50 Christoph Feck wrote:
> On Thursday 15 March 2012 23:29:49 Kevin Ottens wrote:
> > On Thursday 15 March 2012 21:21:07 David Faure wrote:
> > > On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote:
> > > > Client code would then look like:
> > > > QIcon i = KDE::Ico
On Thursday 15 March 2012 23:29:49 Kevin Ottens wrote:
> On Thursday 15 March 2012 21:21:07 David Faure wrote:
> > On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote:
> > > Client code would then look like:
> > > QIcon i = KDE::Icon("foo");
> > > instead of:
> > > QIcon i = KDE::loadIcon("foo");
On Thursday 15 March 2012 21:21:07 David Faure wrote:
> On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote:
> > Looks good to me. We probably want also an overload without the iconLoader
> > parameter I guess.
>
> It default to 0, so I assume you mean for the case where someone wants to
> specif
On Thursday 15 March 2012 19:53:36 Kevin Ottens wrote:
> On Saturday 10 March 2012 13:03:10 David Faure wrote:
> > On Saturday 10 March 2012 11:49:21 David Faure wrote:
> > > Maybe we want to make it a method of
> > > KIconLoader/KIconEngine instead?
> >
> > KIconLoader::loadIcon is already taken
On Saturday 10 March 2012 13:03:10 David Faure wrote:
> On Saturday 10 March 2012 11:49:21 David Faure wrote:
> > Maybe we want to make it a method of
> > KIconLoader/KIconEngine instead?
>
> KIconLoader::loadIcon is already taken (and returns a QPixmap), and
> KIconEngine is an internal class.
>
>
On Tuesday 13 March 2012 12:40:28 Giorgos Tsiapaliwkas wrote:
> Also those are my patches for the move of kpushbutton.
Looks good, trivial enough.
No need to post the "pure moving" patch, it's unreadable and unreviewable.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Noki
On 12 March 2012 09:53, Giorgos Tsiapaliwkas wrote:
> Now, kcolors needs to be linked to kurllabel, kseparator and kpushbutton.
>
Plus the kglobalsettings
--
Giorgos Tsiapaliwkas (terietor)
KDE Developer
terietor.gr
___
Kde-frameworks-devel mailing
On 11 March 2012 11:38, David Faure wrote:
>
> All into the kwidgets frameworks, but can you do that in the frameworks
> branch, after merging or cherry-picking the kwidgets frameworks creation
> into
> it? [cf other emails]
>
If I am correct cherry-picking makes merging harder. So I would prefe
On Sunday 11 March 2012 11:16:01 Giorgos Tsiapaliwkas wrote:
> On 10 March 2012 12:49, David Faure wrote:
> > > > > KGuiItem should move to kguiaddons I think.
> > > > > Which means moving KIcon and KIconLoader/KIconTheme too (KGuiItem
> > > > > depends
> > > > > on it).
>
> So,where should I mov
On 10 March 2012 12:49, David Faure wrote:
>
> > > > KGuiItem should move to kguiaddons I think.
> > > > Which means moving KIcon and KIconLoader/KIconTheme too (KGuiItem
> > > > depends
> > > > on it).
>
So,where should I move KGuiItem, KIcon and KIconLoader/KIconTheme??
--
Giorgos Tsiapaliwka
On Saturday 10 March 2012 11:49:21 David Faure wrote:
> Maybe we want to make it a method of
> KIconLoader/KIconEngine instead?
KIconLoader::loadIcon is already taken (and returns a QPixmap), and
KIconEngine is an internal class.
So a new suggestion would be:
namespace KDE {
QIcon loadIcon(c
On Thursday 08 March 2012 18:23:56 Kevin Ottens wrote:
> On Thursday 08 March 2012 18:08:15 Stephen Kelly wrote:
> > David Faure wrote:
> > > On Thursday 08 March 2012 13:11:37 Giorgos Tsiapaliwkas wrote:
> > >> This is my patch about moving kdialog to staging/kwidgets but I need to
> > >> link to
On Thursday 08 March 2012 18:08:15 Stephen Kelly wrote:
> David Faure wrote:
> > On Thursday 08 March 2012 13:11:37 Giorgos Tsiapaliwkas wrote:
> >> This is my patch about moving kdialog to staging/kwidgets but I need to
> >> link to
> >> KGuiItem(KDialog requires that). I can do then job, but ther
David Faure wrote:
> On Thursday 08 March 2012 13:11:37 Giorgos Tsiapaliwkas wrote:
>> This is my patch about moving kdialog to staging/kwidgets but I need to
>> link to
>> KGuiItem(KDialog requires that). I can do then job, but there was nobody
>> in the channel to approve it. So I didn't.
>
> T
On Thursday 08 March 2012 13:11:37 Giorgos Tsiapaliwkas wrote:
> This is my patch about moving kdialog to staging/kwidgets but I need to
> link to
> KGuiItem(KDialog requires that). I can do then job, but there was nobody in
> the channel to approve it. So I didn't.
This KDialog move looks good.
27 matches
Mail list logo
