Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-11-02 Thread David Faure
On Saturday 27 October 2012 17:56:21 Jon Severinsson wrote: > lördagen den 27 oktober 2012 12:04:31 skrev du: > > On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > > > +QVERIFY(dateTimeInvalidTz.isValid()); > > > > It's still valid? I'm confused :-) > > I attached the wrong f*ing fi

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-27 Thread Jon Severinsson
lördagen den 27 oktober 2012 12:04:31 skrev du: > On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > > +QVERIFY(dateTimeInvalidTz.isValid()); > > It's still valid? I'm confused :-) I attached the wrong f*ing file. Oh well, new try... From d9c886f578fd5bf4e502b67c890c949d2b817191 Mon

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-27 Thread David Faure
On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > +QVERIFY(dateTimeInvalidTz.isValid()); It's still valid? I'm confused :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 signature.asc Description: This is a digitally signed

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread Jon Severinsson
fredagen den 26 oktober 2012 19:23:05 skrev David Faure: > On Friday 26 October 2012 17:30:56 Jon Severinsson wrote: > > I'm no expert either, but I have picked up a few things over the last > > couple of weeks, and IMHO such a KDateTime should be invalid, but not > > null, and toString should res

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread David Faure
On Friday 26 October 2012 17:30:56 Jon Severinsson wrote: > I'm no expert either, but I have picked up a few things over the last couple > of weeks, and IMHO such a KDateTime should be invalid, but not null, and > toString should result in a sensible, though invalid, string. Sounds sensible, but p

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-26 Thread Jon Severinsson
torsdagen den 25 oktober 2012 23:15:21 skrev David Faure: > On Thursday 25 October 2012 22:47:00 Jon Severinsson wrote: > > Getting a valid KDateTime with a "valid but garbage" timezone spec is > > currently as simple as this: > > KTzfileTimeZoneSource source("/invalid/tzinfo/dir"); > > KDateTime

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread David Faure
On Thursday 25 October 2012 22:47:00 Jon Severinsson wrote: > torsdagen den 25 oktober 2012 19:25:29 skrev du: > > On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > > > I triggered this in Qt5 too, and I figured out the underlying reason for > > > it to happen. If, when KSystemTimeZone

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread Jon Severinsson
torsdagen den 25 oktober 2012 19:25:29 skrev du: > On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > > I triggered this in Qt5 too, and I figured out the underlying reason for > > it to happen. If, when KSystemTimeZonesPrivate::setLocalZone() tries to > > figure out what time zone to u

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread David Faure
On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > I triggered this in Qt5 too, and I figured out the underlying reason for it > to happen. If, when KSystemTimeZonesPrivate::setLocalZone() tries to > figure out what time zone to use for KSystemTimeZones::local(), the kconfig > "ktimezon

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-25 Thread Jon Severinsson
fredagen den 19 oktober 2012 20:50:16 skrev David Faure: > diff --git a/kdecore/date/kdatetime.cpp b/kdecore/date/kdatetime.cpp > index 910e1cf..74e82ca 100644 > --- a/kdecore/date/kdatetime.cpp > +++ b/kdecore/date/kdatetime.cpp > @@ -1773,6 +1773,8 @@ QString KDateTime::toString(TimeFormat forma

Re: my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-19 Thread Jon Severinsson
> --- a/kdecore/date/kdatetime.cpp > +++ b/kdecore/date/kdatetime.cpp > @@ -1773,6 +1773,8 @@ QString KDateTime::toString(TimeFormat format) const > offset = d->timeZoneOffset(); // calculate offset and cache > UTC value > else > offset = tz.isValid() ? tz.offs

my own kdatetime patches: toString with InvalidOffset; operator==

2012-10-19 Thread David Faure
diff --git a/kdecore/date/kdatetime.cpp b/kdecore/date/kdatetime.cpp index 910e1cf..74e82ca 100644 --- a/kdecore/date/kdatetime.cpp +++ b/kdecore/date/kdatetime.cpp @@ -1773,6 +1773,8 @@ QString KDateTime::toString(TimeFormat format) const offset = d->timeZoneOffset(); // calculate o