Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
marked as submitted. Review request for KDE Frameworks. Repository: kguiaddons Description --- Print a warning if kimagecache.h is used without KF5::CoreAddons If an application links against KF5::GuiAddons but not KF5::CoreAddons, they cannot use KImageCache. So we use defines (set by

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Commit Hook
org/r/114701/ > --- > > (Updated Dec. 28, 2013, 1:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > --- > > Print a warning if kimagecache.h is

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
/git.reviewboard.kde.org/r/114701/ > --- > > (Updated Dec. 28, 2013, 1:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > --- > > Prin

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread David Faure
ated Dec. 28, 2013, 1:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > --- > > Print a warning if kimagecache.h is used without KF5::CoreAddons > > If an application links against KF5::GuiAddons but

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
> > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > --- > > Print a warning if kimagecache.h is used without KF5::CoreAddons > > If an application links against KF5::GuiAddons but not KF5::CoreAddons, > they cannot

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread David Faure
gt; (Updated Dec. 28, 2013, 1:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > --- > > Print a warning if kimagecache.h is used without KF5::CoreAddons > > If an application links against KF5::GuiAddons but

Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
--- Print a warning if kimagecache.h is used without KF5::CoreAddons If an application links against KF5::GuiAddons but not KF5::CoreAddons, they cannot use KImageCache. So we use defines (set by the exported targets) to check whether the current target has been linked against KF5::CoreAddons

Re: kimagecache.h

2013-12-26 Thread Michael Pyne
On 12/26/2013 12:08 PM, Alex Merry wrote: Well, it's not like KImageCache itself is any use without KCoreAddons. Like I said before, we can put KSharePixmapCacheMixin in its own header file if we think people will actually use it (we don't even have to make that decision until someone comes to us

Re: kimagecache.h

2013-12-26 Thread Alex Merry
On 26/12/13 16:42, Kevin Ottens wrote: > On Thursday 26 December 2013 15:47:49 Alex Merry wrote: >> There are three possible solutions that I see to this: >> 1. just #include in kimagecache.h, on the basis >> KImageCache is useless without linking against KCoreAddons anyway &

Re: kimagecache.h

2013-12-26 Thread Kevin Ottens
Hello, On Thursday 26 December 2013 15:47:49 Alex Merry wrote: > Another decision to be made :-) > > kimagecache.h, in KGuiAddons, includes the template class > KSharedPixmapCacheMixin and the line > #define KImageCache KSharedPixmapCacheMixin > > Using KImageCache will cle

kimagecache.h

2013-12-26 Thread Alex Merry
Another decision to be made :-) kimagecache.h, in KGuiAddons, includes the template class KSharedPixmapCacheMixin and the line #define KImageCache KSharedPixmapCacheMixin Using KImageCache will clearly not work without the header that defines KSharedDataCache, which is in kcoreaddons. Currently