Re: fix frameworks-kactions compile error

2012-04-19 Thread Kevin Ottens
On Thursday 19 April 2012 12:03:01 David Faure wrote: > On Wednesday 18 April 2012 21:39:05 Kevin Ottens wrote: > > > KDirWatch needs to still exist, given that there is a Qt equivalent). > > > > Yes, I've been wondering about KDirWatch lately... We used to keep it > > because of some QFileSystemW

Re: fix frameworks-kactions compile error

2012-04-19 Thread David Faure
On Wednesday 18 April 2012 21:39:05 Kevin Ottens wrote: > > KDirWatch needs to still exist, given that there is a Qt equivalent). > > Yes, I've been wondering about KDirWatch lately... We used to keep it > because of some QFileSystemWatcher limitations. Maybe it's not relevant > anymore, IIRC Dav

Re: fix frameworks-kactions compile error

2012-04-18 Thread Kevin Ottens
On Wednesday 18 April 2012 10:21:36 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote: > >> It might be useful to have an objective way to know whether a widget > >> should be on a framework on its own or grouped with something else > >> though. Doe

Re: fix frameworks-kactions compile error

2012-04-18 Thread Stephen Kelly
Kevin Ottens wrote: > On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote: >> It might be useful to have an objective way to know whether a widget >> should be on a framework on its own or grouped with something else >> though. Does size matter? >> >> Personally I think it should be something li

Re: fix frameworks-kactions compile error

2012-04-17 Thread Kevin Ottens
On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote: > Kevin Ottens wrote: > >> kplotting also doesn't depend on either of the above plotting engines, > >> let alone both of them, so I guess I didn't understand what you wrote > >> here or why having kplotwidget grouped with other widgets would mea

Re: fix frameworks-kactions compile error

2012-04-15 Thread Stephen Kelly
Kevin Ottens wrote: >> kplotting also doesn't depend on either of the above plotting engines, >> let alone both of them, so I guess I didn't understand what you wrote >> here or why having kplotwidget grouped with other widgets would mean >> dragging them in. > > I meant that someone who would wan

Re: Using KColorScheme in style only (Was: fix frameworks-kactions compile error)

2012-04-15 Thread Stephen Kelly
Kevin Ottens wrote: >> Hugo, any ideas/comment on this? The background is here: >> >> http://thread.gmane.org/gmane.comp.kde.devel.frameworks/473/focus=485 > > Missing a CC? KNode seems to have dropped it, but I notified him 'manually' by email anyway about the thread. Thanks, Steve. __

Re: fix frameworks-kactions compile error

2012-04-14 Thread Kevin Ottens
On Saturday 14 April 2012 19:19:51 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: > >> So here's my proposal: > >> > >> * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a > >> framework which depends only on QtWidgets.

Re: Using KColorScheme in style only (Was: fix frameworks-kactions compile error)

2012-04-14 Thread Kevin Ottens
On Saturday 14 April 2012 19:27:36 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: > >> [...] > >> At the center of the questions of what to do with KUrlLabel and > >> KCapacityBar are the question of what to do about their KColorScheme > >> d

Using KColorScheme in style only (Was: fix frameworks-kactions compile error)

2012-04-14 Thread Stephen Kelly
Kevin Ottens wrote: > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: >> [...] >> At the center of the questions of what to do with KUrlLabel and >> KCapacityBar are the question of what to do about their KColorScheme >> dependency. Their use of KColorScheme seems to me like something that

Re: fix frameworks-kactions compile error

2012-04-14 Thread Stephen Kelly
Kevin Ottens wrote: > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: >> So here's my proposal: >> >> * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a >> framework which depends only on QtWidgets. The widgets in there should be >> self-contained and not rely on a

Re: fix frameworks-kactions compile error

2012-04-13 Thread Stephen Kelly
Kevin Ottens wrote: > On Wednesday 11 April 2012 18:59:26 Stephen Kelly wrote: >> David Faure wrote: >> > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think. >> >> That would make kguiaddons depend on QtWidgets, which may not be what we >> want (QIcon is in widgets). > > It's rea

Re: fix frameworks-kactions compile error

2012-04-12 Thread Kevin Ottens
On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: > So here's my proposal: > > * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a > framework which depends only on QtWidgets. The widgets in there should be > self-contained and not rely on any 'KDE stuff' (This is one o

Re: fix frameworks-kactions compile error

2012-04-12 Thread Kevin Ottens
On Wednesday 11 April 2012 18:59:26 Stephen Kelly wrote: > David Faure wrote: > > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think. > > That would make kguiaddons depend on QtWidgets, which may not be what we > want (QIcon is in widgets). It's really an unfortunate decision on th

Re: fix frameworks-kactions compile error

2012-04-11 Thread Stephen Kelly
Giorgos Tsiapaliwkas wrote: > On 11 April 2012 19:59, Stephen Kelly wrote: >> >> That depends on what is supposed to go into kwidgets, which I wrote >> previously is not clear or decided yet. > > what should we do with this one? We should talk about what should be moved, and why, and what depen

Re: fix frameworks-kactions compile error

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 19:59, Stephen Kelly wrote: > > That depends on what is supposed to go into kwidgets, which I wrote > previously is not clear or decided yet. what should we do with this one? I haven't changed anything to my branch and I won't until the frameworks team decide what kwidgets shou

Re: fix frameworks-kactions compile error

2012-04-11 Thread Giorgos Tsiapaliwkas
On 11 April 2012 18:36, David Faure wrote: > > kwidgets doesn't need kactions, does it? If so, then we need to rethink > this. > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think. > yes it does. We can't link them due to a circular. -- Giorgos Tsiapaliwkas (terietor) KDE Develo

Re: fix frameworks-kactions compile error

2012-04-11 Thread Stephen Kelly
David Faure wrote: > On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote: >> Hello, >> >> I am trying to finish the frameworks-kactions branch but i cannot fix a >> compile error. >> Here is the error http://paste.kde.org/455594/ >> >> And those are the local changes that i have made

Re: fix frameworks-kactions compile error

2012-04-11 Thread David Faure
On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote: > Hello, > > I am trying to finish the frameworks-kactions branch but i cannot fix a > compile error. > Here is the error http://paste.kde.org/455594/ > > And those are the local changes that i have made to frameworks-kactions > >