D21299: examples: move codeeditor also in own subdir

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e3a7922ae842: examples: move codeeditor also in own subdir (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21299?vs=58330&id=58349#toc REPOSITORY R216 Sy

D21299: examples: move codeeditor also in own subdir

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! I was about to propose this for consistency as well, please go ahead. REPOSITORY R216 Syntax Highlighting BRANCH haveonesubdirperexample REVISION DETAIL https://phabricat

D21299: examples: move codeeditor also in own subdir

/D21299 AFFECTED FILES examples/CMakeLists.txt examples/codeeditor.cpp examples/codeeditor.h examples/codeeditor/CMakeLists.txt examples/codeeditor/codeeditor.cpp examples/codeeditor/codeeditor.h examples/codeeditor/main.cpp examples/main.cpp To: kossebau Cc: kwrite-devel, kde

D13571: Correct KFormat::formatBytes examples

This revision was automatically updated to reflect the committed changes. Closed by commit R244:59dc873bcbe1: Correct KFormat::formatBytes examples (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13571?vs=36731&id=37744 REVI

D13571: Correct KFormat::formatBytes examples

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this is an improvement. Even if it can be improved even more, I believe it is better to push this instead of postponing a commit. REPOSITORY R244 KCoreAddons BRANCH kformat

D13571: Correct KFormat::formatBytes examples

bruns marked 2 inline comments as done. bruns added a comment. ping! REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13571 To: bruns, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

bruns updated this revision to Diff 36731. bruns added a comment. Use @code/@endcode Reword extended documentation for precision parameter REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13571?vs=36234&id=36731 BRANCH kformat_doc REVISION DETAIL

D13571: Correct KFormat::formatBytes examples

bruns added a comment. In D13571#280135 , @apol wrote: > In D13571#279554 , @bruns wrote: > > > In D13571#279550 , @apol wrote: > > > > > > The given exa

D13571: Correct KFormat::formatBytes examples

apol added a comment. In D13571#279554 , @bruns wrote: > In D13571#279550 , @apol wrote: > > > > The given example is just plain wrong. It does not work, it is just some false prosa. > > > > Fair

D13571: Correct KFormat::formatBytes examples

bruns added inline comments. INLINE COMMENTS > kformattest.cpp:37 > QCOMPARE(format.formatByteSize(0), QStringLiteral("0 B")); > QCOMPARE(format.formatByteSize(50), QStringLiteral("50 B")); > QCOMPARE(format.formatByteSize(500), QStringLiteral("500 B")); See here for handling of p

D13571: Correct KFormat::formatBytes examples

bruns added a comment. In D13571#279550 , @apol wrote: > > The given example is just plain wrong. It does not work, it is just some false prosa. > > Fair enough, yet the API user may want to be able to understand what's the logic behind it,

D13571: Correct KFormat::formatBytes examples

apol added a comment. > The given example is just plain wrong. It does not work, it is just some false prosa. Fair enough, yet the API user may want to be able to understand what's the logic behind it, so if it can be explained on the documentation that could be useful. INLINE COMMENTS

D13571: Correct KFormat::formatBytes examples

bruns marked an inline comment as done. bruns added a comment. In D13571#279453 , @apol wrote: > Then explain why it works? Actually the former behaviour is what I'd expect. The given example is just plain wrong. It does not work, it is ju

D13571: Correct KFormat::formatBytes examples

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > apol wrote in kformat.h:184 > What's "resp."? respectively REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13571 To: bruns, #frameworks Cc: apol, kde-frameworks-devel, michaelh,

D13571: Correct KFormat::formatBytes examples

apol added a comment. Then explain why it works? Actually the former behaviour is what I'd expect. INLINE COMMENTS > kformat.h:184 > + *1 by default so when in doubt use 1. Integral values less than > 1000 > + *resp. 1024 always omit the fractional part. > * @pa

D13571: Correct KFormat::formatBytes examples

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The example left out the "precision" parameter, reported

D10092: [Examples] Fix build

This revision was automatically updated to reflect the committed changes. Closed by commit R242:595fd8805430: [Examples] Fix build (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10092?vs=25923&id=25992 REVISION DE

D10092: [Examples] Fix build

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. LGTM. The examples seem to have a circular runtime dependency on (at least) plasma-desktop. Is that just an opportunistic dependency (= they'd work fine you'd only just instal

D10092: [Examples] Fix build

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10092 To: broulik, #plasma, rjvbb Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10092: [Examples] Fix build

broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added reviewers: Plasma, rjvbb. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAI

D10092: [Examples] Fix build

examples/dataengines/customDataContainers/customDataContainersEngine.cpp examples/dataengines/customDataContainers/customDataContainersEngine.h examples/dataengines/customDataContainers/httpContainer.cpp examples/dataengines/customDataContainers/httpContainer.h examples/dataengines

D5032: drop examples dir

This revision was automatically updated to reflect the committed changes. Closed by commit R308:5ea3c8759505: drop examples dir (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5032?vs=12428&id=19968#toc REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE h

D5032: drop examples dir

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

sitter added a comment. Not interesting enough to me. If someone finds it interesting, sure. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

ltoscano added a comment. Couldn't it go to kdeexamples if interesting enough (or at least its frameworks branch, if any?) REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

ION DETAIL https://phabricator.kde.org/D5032 AFFECTED FILES examples/runner/CMakeLists.txt examples/runner/Messages.sh examples/runner/homefilesrunner.cpp examples/runner/homefilesrunner.h examples/runner/plasma-runner-example-homefiles.desktop To: sitter, broulik Cc: #frameworks

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

the KJob (ExecuteJob) usage. Diffs - CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 examples/CMakeLists.txt PRE-CREATION examples/client.cpp PRE-CREATION examples/helper.cpp PRE-CREATION metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448 src/kauthactionreply.h

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

are just removed, in particular the section about > executing the actions asynchronously, which predates the KJob (ExecuteJob) > usage. > > > Diffs > - > > CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 > examples/CMakeLists.txt PRE-CREATION

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

> Diffs > - > > CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 > examples/CMakeLists.txt PRE-CREATION > examples/client.cpp PRE-CREATION > examples/helper.cpp PRE-CREATION > metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448 > src/kauthac

Review Request 129842: KAuth: update most of the examples, drop outdated ones

particular the section about executing the actions asynchronously, which predates the KJob (ExecuteJob) usage. Diffs - CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 examples/CMakeLists.txt PRE-CREATION examples/client.cpp PRE-CREATION examples/helper.cpp PRE-CREATION

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123348/ > --- > > (Updated April 17, 2015, 2:10 p.m.) > > > Review request for KDE Fra

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

il 17, 2015, 2:10 p.m.) > > > Review request for KDE Frameworks and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > --- > > The examples didn't build because didn't exist > locally in the builddir. Using ecm_generate_headers

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

marked as submitted. Review request for KDE Frameworks and Jan Grulich. Changes --- Submitted with commit 99668971cc1c33712ac088a6a05101d0a9c09253 by David Faure to branch master. Repository: networkmanager-qt Description --- The examples didn't build because didn&#x

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

il 12, 2015, 7:51 p.m.) > > > Review request for KDE Frameworks and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > --- > > The examples didn't build because didn't exist > locally in the builddir. Using ecm_generate_h

Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

: networkmanager-qt Description --- The examples didn't build because didn't exist locally in the builddir. Using ecm_generate_headers properly for such a namespaced framework (i.e. with PREFIX, like KParts does) fixes that, and makes the installation of the headers more standard: Networ

Re: Snippetextractor comments in framework examples

g >> > snippetextractor comments in the examples to be able to directly quote >> > things in the book from the examples in the framework we're writing >> > about. > No objection. I wonder if this can be useful for the apidox too -- just like > Qt marks code for ex

Re: Snippetextractor comments in framework examples

On Monday 11 August 2014 10:34:40 Rohan Garg wrote: > Hi everyone > As part of writing the KDE Frameworks 5 book, we were wondering if > it's fine with all the framework maintainers if we started adding > snippetextractor comments in the examples to be able to directly quote >

Re: KF5 ThreadWeaver Examples?

code. I'm not sure where else to look. Any suggestions? Sorry for the late response. I just came back from the Randa meeting. You can now find examples in the ThreadWeaver repo, and 10 pages of introduction in kde:kf5book. Have fun, and if you have any questions, please let me know. Mirko

Re: Snippetextractor comments in framework examples

Hi! El 11/08/2014 10:35, "Rohan Garg" escribió: > > Hi everyone > As part of writing the KDE Frameworks 5 book, we were wondering if > it's fine with all the framework maintainers if we started adding > snippetextractor comments in the examples to be able to direc

Snippetextractor comments in framework examples

Hi everyone As part of writing the KDE Frameworks 5 book, we were wondering if it's fine with all the framework maintainers if we started adding snippetextractor comments in the examples to be able to directly quote things in the book from the examples in the framework we're writing a

KF5 ThreadWeaver Examples?

Hi, I'm interested in toying around with ThreadWeaver in my Qt5 application. I installed ThreadWeaver on my Fedora box from the repo on COPR. I can't find any example code. I'm not sure where else to look. Any suggestions? Thanks Brian -- Duff ___ Kd

Re: Review Request 117974: Some more KArchive examples

marked as submitted. Review request for KDE Frameworks. Repository: karchive Description --- 2 extra examples on how to use the KArchive framework. Together with the 2 we already have most of the basic usage is covered. unzipper: Shows how to extract files from an archive bzip2gzip

Re: Review Request 117974: Some more KArchive examples

org/r/117974/ > --- > > (Updated June 6, 2014, 7:15 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > --- > > 2 extra examples on how to use

Re: Review Request 117974: Some more KArchive examples

une 6, 2014, 7:15 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > --- > > 2 extra examples on how to use the KArchive framework. Together with the 2 we > already have most of the basic usage is cov

Re: Review Request 117974: Some more KArchive examples

> On May 12, 2014, 3:16 p.m., Kevin Ottens wrote: > > examples/bzip2gzip/main.cpp, line 74 > > <https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74> > > > > Maybe a better idea to use a loop to avoid the readAll? I know that's

Re: Review Request 117974: Some more KArchive examples

. Changes --- Don't read all data at once. More scalable with big files. I was unsure about the amount of bytes we should read per loop. 512 is the magic number. Repository: karchive Description --- 2 extra examples on how to use the KArchive framework. Together with the 2 we al

Re: Review Request 117974: Some more KArchive examples

> On May 12, 2014, 3:16 p.m., Kevin Ottens wrote: > > examples/bzip2gzip/main.cpp, line 74 > > <https://git.reviewboard.kde.org/r/117974/diff/1/?file=271400#file271400line74> > > > > Maybe a better idea to use a loop to avoid the readAll? I know that's

Re: Review Request 117974: Some more KArchive examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review57784 --- examples/bzip2gzip/main.cpp <https://git.reviewboard.kde.

Review Request 117974: Some more KArchive examples

--- 2 extra examples on how to use the KArchive framework. Together with the 2 we already have most of the basic usage is covered. unzipper: Shows how to extract files from an archive bzip2gzip: Example about KCompressionDevice They are BSD licensed because I consider that a good license for

Re: Review Request 115222: use renamed kjscmd5 in examples

rd.kde.org/r/115222/ > --- > > (Updated Jan. 22, 2014, 12:42 p.m.) > > > Review request for KDE Frameworks and Hrvoje Senjan. > > > Repository: kjsembed > > > Description > ---

Re: Review Request 115222: use renamed kjscmd5 in examples

marked as submitted. Review request for KDE Frameworks and Hrvoje Senjan. Repository: kjsembed Description --- use renamed kjscmd5 in examples Diffs - examples/calc/calc.js 1cf93dd examples/docviewer/docviewer.js 668c6fd examples/fancy/fancy.js bd5a644 examples/grammar

Re: Review Request 115222: use renamed kjscmd5 in examples

Jan. 22, 2014, 12:42 p.m.) > > > Review request for KDE Frameworks and Hrvoje Senjan. > > > Repository: kjsembed > > > Description > --- > > use renamed kjscmd5 in examples > > > Diffs > - > > examples/calc/calc.js 1cf93d

Re: Review Request 115222: use renamed kjscmd5 in examples

oard.kde.org/r/115222/ > --- > > (Updated Jan. 22, 2014, 12:42 p.m.) > > > Review request for KDE Frameworks and Hrvoje Senjan. > > > Repository: kjsembed > > > Description > --- > > use renamed kjscmd5 in e

Review Request 115222: use renamed kjscmd5 in examples

: kjsembed Description --- use renamed kjscmd5 in examples Diffs - examples/calc/calc.js 1cf93dd examples/docviewer/docviewer.js 668c6fd examples/fancy/fancy.js bd5a644 examples/grammar/grammar.js 7f3ee1e examples/scribble/scribble.js 80fc97d examples/tests/statictest.js

Re: Review Request 113910: Add basic KArchive examples

marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on

Re: Review Request 113910: Add basic KArchive examples

rd.kde.org/r/113910/ > --- > > (Updated Nov. 25, 2013, 2:46 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > This adds 2 examples to KA

Re: Review Request 113910: Add basic KArchive examples

v. 25, 2013, 2:46 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > This adds 2 examples to KArchive. > - helloworld: Very basic. Shows how to use with CMake and create archives. > - tarlocalfile

Re: Review Request 113910: Add basic KArchive examples

> On Nov. 25, 2013, 2:11 p.m., Kevin Ottens wrote: > > tier1/karchive/examples/tarlocalfiles/main.cpp, line 72 > > <http://git.reviewboard.kde.org/r/113910/diff/2/?file=219629#file219629line72> > > > > Put the } and the else if on the same line please. > &

Re: Review Request 113910: Add basic KArchive examples

. Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on: License? Currently BSD. Code comments. More, less? Readability

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44406 --- tier1/karchive/examples/tarlocalfiles/main.cpp <h

Re: Review Request 113910: Add basic KArchive examples

. Changes --- Simplify the example. Add REQUIRED keyword Repository: kdelibs Description --- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on

Re: Review Request 113910: Add basic KArchive examples

ity? Looks good to me. > Other examples I'm working on: > helloworld with qmake > something with KCompressionDevice > perhaps a minimal ark like example Thanks for working on this! It's a great initiative. tier1/karchive/examples/helloworld/CMakeLists.txt <http://git.revi

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44222 --- tier1/karchive/examples/helloworld/main.cpp <h

Review Request 113910: Add basic KArchive examples

--- This adds 2 examples to KArchive. - helloworld: Very basic. Shows how to use with CMake and create archives. - tarlocalfiles: Shows how to add local files to an archive. Looking for feedback on: License? Currently BSD. Code comments. More, less? Readability? Other examples I'm worki

Re: examples

On Thursday, December 8, 2011 21:39:53 Alexander Neundorf wrote: > So if it is a separate library, having the examples with the library is this makes exactly the point: we want people using as many of our libraries as possible, so we are motivated to make that as easy as possible. there are

Re: examples

On Tuesday 06 December 2011, Stephen Kelly wrote: > Oswald Buddenhagen wrote: > > On Mon, Dec 05, 2011 at 09:50:09AM +0100, Aaron J. Seigo wrote: > >> On Monday, December 5, 2011 09:24:07 Oswald Buddenhagen wrote: > >> > examples have to live in their paren

Re: examples

On Tue, Dec 6, 2011 at 12:55 AM, Sune Vuorela wrote: > As one who has a bit of packaging experience. > > if examples for libfoo got installed when apidocs were built and installed > into PREFIX/share/doc/(lib)foo then I'm sure most distros would ship the > examples together wi

Re: examples

rules. works for > qt, after all - despite qmake. adjusting packaging rules accordingly is > a total non-issue. As one who has a bit of packaging experience. if examples for libfoo got installed when apidocs were built and installed into PREFIX/share/doc/(lib)foo then I'm sure most distro

Re: examples

On Tuesday 06 December 2011 10:32:34 Mario Fux wrote: > So why not leaving the examples in examples directories in the frameworks > and building some cmake or what magic to create a tarball or something with > all examples collected. Probably together with the (new) KDE demo app done >

Re: examples

Oswald Buddenhagen wrote: > On Mon, Dec 05, 2011 at 09:50:09AM +0100, Aaron J. Seigo wrote: >> On Monday, December 5, 2011 09:24:07 Oswald Buddenhagen wrote: >> > examples have to live in their parent module so they can be linked >> > from the docs. >> &

Re: examples

On Tuesday, December 6, 2011 10:32:34 Mario Fux wrote: > So why not leaving the examples in examples directories in the frameworks > and building some cmake or what magic to create a tarball or something with > all examples collected. Probably together with the (new) KDE demo app do

Re: examples

Morning Sometimes it's not the best idea to offer all choices but probably this time. I think it makes sense to leave the examples in an examples directory in each frameworks as this example code normally doesn't build without the framework itself. On the other side there are quite s

Re: examples

On Mon, Dec 05, 2011 at 09:50:09AM +0100, Aaron J. Seigo wrote: > On Monday, December 5, 2011 09:24:07 Oswald Buddenhagen wrote: > > examples have to live in their parent module so they can be linked > > from the docs. > > that's a very interesting point. > howe

Re: examples

On Monday, December 5, 2011 09:24:07 Oswald Buddenhagen wrote: > On Mon, Dec 05, 2011 at 12:05:13AM +0100, Aaron J. Seigo wrote: > > source code examples are to live in an examples/ directory within the > > given > > framework git module. to put it simple: i object :) > &g

Re: examples

On Mon, Dec 05, 2011 at 12:05:13AM +0100, Aaron J. Seigo wrote: > source code examples are to live in an examples/ directory within the given > framework git module. to put it simple: i object :) > and i deflect. :P this topic was discussed ad nauseam in qtdf. examples have to live

examples

hi .. according to this: http://community.kde.org/Frameworks/Policies#Framework_directory_structure source code examples are to live in an examples/ directory within the given framework git module. to put it simple: i object :) kdeexamples exists as a way to bring together example code for