This revision was automatically updated to reflect the committed changes.
Closed by commit R239:4b70fd9ae983: Fix mingw compile error
"src/kdeui/kapplication_win.cpp:212:22: error: 'kill'… (authored
by habacker).
REPOSITORY
R239 KDELibs4Support
CHANGES SINCE LAST
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R239 KDELibs4Support
BRANCH
arcpatch-D9404
REVISION DETAIL
https://phabricator.kde.org/D9404
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
habacker updated this revision to Diff 24158.
habacker added a comment.
- removed unrelated AFTER parameter
REPOSITORY
R239 KDELibs4Support
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9404?vs=24090&id=24158
BRANCH
arcpatch-D9404
REVISION DETAIL
https://phabricator.kde.org
habacker added a comment.
In https://phabricator.kde.org/D9404#181209, @dfaure wrote:
> So the if() is needed,
yes,
> the AFTER isn't enough?
I tried that and it does not help - AFTER|BEFORE affects only the order of
directories added with include_directories
> I wo
dfaure added a comment.
So the if() is needed, the AFTER isn't enough?
I wonder how AFTER works in combination with linking to targets that provide
include dirs.
This looks all a bit hackish, but I don't have a better suggestion other than
this possible simplification.
REPOSITORY
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This fixes also similar error with msvc in case openssl development
header has been installed into the same location as KDEWin.
TEST PLAN
habacker added reviewers: dfaure, ltoscano, bcooksley.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D9404
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
discarded.
Review request for KDE Frameworks and Albert Astals Cid.
Repository: kcoreaddons
Description
---
This patch fixes a cross compile error of the mingw32-kcoreaddons package on
opensuse.
Diffs
-
src/lib/util/kuser_win.cpp 8f8933c
Diff: https://git.reviewboard.kde.org
marked as submitted.
Review request for KDE Frameworks.
Repository: karchive
Description
---
Fix cross compile error caused by using upper case Windows.h include header
file name.
Diffs
-
src/karchive.cpp 4459d351caf17f9feea1d13d3870f35f12ba27cb
Diff: https
.
Summary (updated)
-
Fix cross compile error caused by using upper case Windows.h include header
file name.
Repository: karchive
Description (updated)
---
Fix cross compile error caused by using upper case Windows.h include header
file name.
Diffs
-
src/karchive.cpp
tory: karchive
>
>
> Description
> ---
>
> Fix cross compile error using Windows.h instead correctly windows.h.
>
>
> Diffs
> -
>
> src/karchive.cpp 4459d351caf17f9feea1d13d3870f35f12ba27cb
>
> Diff: https://git.reviewboard.kde.org/r/12186
---
Fix cross compile error using Windows.h instead correctly windows.h.
Diffs
-
src/karchive.cpp 4459d351caf17f9feea1d13d3870f35f12ba27cb
Diff: https://git.reviewboard.kde.org/r/121865/diff/
Testing
---
compiled package at
https://build.opensuse.org/package/show
and Albert Astals Cid.
Repository: kcoreaddons
Description
---
This patch fixes a cross compile error of the mingw32-kcoreaddons package on
opensuse.
Diffs
-
src/lib/util/kuser_win.cpp 8f8933c
Diff: https://git.reviewboard.kde.org/r/121852/diff/
Testing
---
Checked with
On Saturday 04 January 2014 13:33:59 Dominik Haumann wrote:
> Building KIO:
>
> In file included from
> /home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0:
> /home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error:
> ki18n/klocalizedstring.h: No such file or direct
Building KIO:
In file included from
/home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0:
/home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error:
ki18n/klocalizedstring.h: No such file or directory
#include "ki18n/klocalizedstring.h"
On Thursday 19 April 2012 12:03:01 David Faure wrote:
> On Wednesday 18 April 2012 21:39:05 Kevin Ottens wrote:
> > > KDirWatch needs to still exist, given that there is a Qt equivalent).
> >
> > Yes, I've been wondering about KDirWatch lately... We used to keep it
> > because of some QFileSystemW
On Wednesday 18 April 2012 21:39:05 Kevin Ottens wrote:
> > KDirWatch needs to still exist, given that there is a Qt equivalent).
>
> Yes, I've been wondering about KDirWatch lately... We used to keep it
> because of some QFileSystemWatcher limitations. Maybe it's not relevant
> anymore, IIRC Dav
On Wednesday 18 April 2012 10:21:36 Stephen Kelly wrote:
> Kevin Ottens wrote:
> > On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote:
> >> It might be useful to have an objective way to know whether a widget
> >> should be on a framework on its own or grouped with something else
> >> though. Doe
Kevin Ottens wrote:
> On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote:
>> It might be useful to have an objective way to know whether a widget
>> should be on a framework on its own or grouped with something else
>> though. Does size matter?
>>
>> Personally I think it should be something li
On Sunday 15 April 2012 15:54:14 Stephen Kelly wrote:
> Kevin Ottens wrote:
> >> kplotting also doesn't depend on either of the above plotting engines,
> >> let alone both of them, so I guess I didn't understand what you wrote
> >> here or why having kplotwidget grouped with other widgets would mea
Kevin Ottens wrote:
>> kplotting also doesn't depend on either of the above plotting engines,
>> let alone both of them, so I guess I didn't understand what you wrote
>> here or why having kplotwidget grouped with other widgets would mean
>> dragging them in.
>
> I meant that someone who would wan
Kevin Ottens wrote:
>> Hugo, any ideas/comment on this? The background is here:
>>
>> http://thread.gmane.org/gmane.comp.kde.devel.frameworks/473/focus=485
>
> Missing a CC?
KNode seems to have dropped it, but I notified him 'manually' by email
anyway about the thread.
Thanks,
Steve.
__
On Saturday 14 April 2012 19:19:51 Stephen Kelly wrote:
> Kevin Ottens wrote:
> > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote:
> >> So here's my proposal:
> >>
> >> * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a
> >> framework which depends only on QtWidgets.
On Saturday 14 April 2012 19:27:36 Stephen Kelly wrote:
> Kevin Ottens wrote:
> > On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote:
> >> [...]
> >> At the center of the questions of what to do with KUrlLabel and
> >> KCapacityBar are the question of what to do about their KColorScheme
> >> d
Kevin Ottens wrote:
> On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote:
>> [...]
>> At the center of the questions of what to do with KUrlLabel and
>> KCapacityBar are the question of what to do about their KColorScheme
>> dependency. Their use of KColorScheme seems to me like something that
Kevin Ottens wrote:
> On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote:
>> So here's my proposal:
>>
>> * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a
>> framework which depends only on QtWidgets. The widgets in there should be
>> self-contained and not rely on a
Kevin Ottens wrote:
> On Wednesday 11 April 2012 18:59:26 Stephen Kelly wrote:
>> David Faure wrote:
>> > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think.
>>
>> That would make kguiaddons depend on QtWidgets, which may not be what we
>> want (QIcon is in widgets).
>
> It's rea
On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote:
> So here's my proposal:
>
> * kplotting should be renamed and repurposed as kwidgetsaddons (tier1), a
> framework which depends only on QtWidgets. The widgets in there should be
> self-contained and not rely on any 'KDE stuff' (This is one o
On Wednesday 11 April 2012 18:59:26 Stephen Kelly wrote:
> David Faure wrote:
> > Actually, KIcon* should be in kguiaddons, not in kwidgets, I think.
>
> That would make kguiaddons depend on QtWidgets, which may not be what we
> want (QIcon is in widgets).
It's really an unfortunate decision on th
Giorgos Tsiapaliwkas wrote:
> On 11 April 2012 19:59, Stephen Kelly wrote:
>>
>> That depends on what is supposed to go into kwidgets, which I wrote
>> previously is not clear or decided yet.
>
> what should we do with this one?
We should talk about what should be moved, and why, and what depen
On 11 April 2012 19:59, Stephen Kelly wrote:
>
> That depends on what is supposed to go into kwidgets, which I wrote
> previously is not clear or decided yet.
what should we do with this one?
I haven't changed anything to my branch and I won't until the frameworks
team decide what
kwidgets shou
On 11 April 2012 18:36, David Faure wrote:
>
> kwidgets doesn't need kactions, does it? If so, then we need to rethink
> this.
> Actually, KIcon* should be in kguiaddons, not in kwidgets, I think.
>
yes it does. We can't link them due to a circular.
--
Giorgos Tsiapaliwkas (terietor)
KDE Develo
David Faure wrote:
> On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote:
>> Hello,
>>
>> I am trying to finish the frameworks-kactions branch but i cannot fix a
>> compile error.
>> Here is the error http://paste.kde.org/455594/
>>
>>
On Wednesday 11 April 2012 18:16:37 Antonis Tsiapaliokas wrote:
> Hello,
>
> I am trying to finish the frameworks-kactions branch but i cannot fix a
> compile error.
> Here is the error http://paste.kde.org/455594/
>
> And those are the local changes that i have made t
34 matches
Mail list logo
