Re: bic in kactivities

2018-05-30 Thread Ivan Čukić
Marco, thanks for reverting this. @Laurent The proper change for the constructor should be to make the Private class take the shownStates by value (a sink constructor argument) and for the ActivitiesModel constructor to std::move it when passing to the Private constructor. @All - ` explicit` sh

Re: bic in kactivities

2018-05-30 Thread Marco Martin
On Wed, May 30, 2018 at 10:14 AM Harald Sitter wrote: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > > You cannot...For existing functions of any type:change its signature. This includes:changing any of the types of the arguments in the parameter list, including cha

Re: bic in kactivities

2018-05-30 Thread Christoph Feck
On 30.05.2018 10:13, Harald Sitter wrote: Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B You cannot...For ex

bic in kactivities

2018-05-30 Thread Harald Sitter
Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > You cannot...For existing functions of any type:change its sig