Re: Windows patches

2012-07-05 Thread Patrick Spendrin
Am 04.07.2012 16:20, schrieb Stephen Kelly: > Patrick Spendrin wrote: > >> Hi everybody, >> >> I am now half way through building kdelibs frameworks branch on windows. >> >> Some things I want to mention: >> - most unittests are console applications on Windows and so they need to >> be linked agai

Re: Windows patches

2012-07-05 Thread David Faure
On Wednesday 04 July 2012 16:20:05 Stephen Kelly wrote: > It might make sense to get as much as possible into Qt. For example, create > a qSetEnv which calls ::setenv or SetEnvironmentVariable. Qt has qputenv already, in both Qt4 and Qt5, please use that. -- David Faure, fa...@kde.org, http://w

Re: Windows patches

2012-07-04 Thread Stephen Kelly
Patrick Spendrin wrote: > Hi everybody, > > I am now half way through building kdelibs frameworks branch on windows. > > Some things I want to mention: > - most unittests are console applications on Windows and so they need to > be linked against the stub library qtmain.lib. I committed a patch

Windows patches

2012-07-04 Thread Patrick Spendrin
Hi everybody, I am now half way through building kdelibs frameworks branch on windows. Some things I want to mention: - most unittests are console applications on Windows and so they need to be linked against the stub library qtmain.lib. I committed a patch which does this already for quite a lot