T12641: Refactor KFileProtocol::copy

2021-10-18 Thread Méven Car
meven added a comment. Found some hints how to help the kernel manage its buffers and page cache efficiently when writing http://lkml.iu.edu/hypermail/linux/kernel/1005.2/01845.html http://lkml.iu.edu/hypermail/linux/kernel/1005.2/01953.html Also additional fadvise might be worse test

T12641: Refactor KFileProtocol::copy

2021-10-13 Thread Méven Car
meven added a comment. I have a first step : split to two loops use copy_file_range https://invent.kde.org/frameworks/kio/-/merge_requests/602 TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, sdorishlab, badbunny

T12641: Refactor KFileProtocol::copy

2021-10-05 Thread Méven Car
meven added a comment. The io_uring cp example is a good reference to make use of the API. https://github.com/axboe/liburing/blob/master/examples/io_uring-cp.c TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, sdorish

T12641: Refactor KFileProtocol::copy

2021-10-01 Thread Méven Car
meven added a comment. copy https://github.com/coreutils/coreutils/blob/master/src/copy.c#L301 use https://man7.org/linux/man-pages/man2/copy_file_range.2.html or https://github.com/coreutils/gnulib/blob/master/lib/full-write.h Did not know about copy_file_range, it was introduced in kernel

T12641: Refactor KFileProtocol::copy

2020-04-04 Thread Méven Car
meven updated the task description. TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromor

T12641: Refactor KFileProtocol::copy

2020-02-15 Thread David Faure
dfaure added a comment. I don't really understand the relation to ksmserver, surely kioslaves are not part of session management. I also don't really understand what would happen in the new event loop (select/poll) of the kioslave while the non-blocking I/O is happening. It's not like t

T12641: Refactor KFileProtocol::copy

2020-02-12 Thread Méven Car
meven added a comment. @dfaure does this makes sense to you ? TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, m

T12641: Refactor KFileProtocol::copy

2020-02-04 Thread Méven Car
meven created this task. meven triaged this task as "Normal" priority. meven added projects: Frameworks, Dolphin. TASK DESCRIPTION Our man file copy function has some glaring issues that I'd like to tackle in a few steps: - Split the sendfile and read/write code path to function, to make e