Re: Review Request 130228: Mingw32 compile fix

2018-03-25 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130228/ --- (Updated March 25, 2018, 3:09 p.m.) Status -- This change has been m

Re: Review Request 130228: Mingw32 compile fix

2018-03-25 Thread Ralf Habacker
> On Aug. 17, 2017, 10:14 a.m., David Faure wrote: > > Looks OK. Nice code duplication, but ok, this is kdelibs4support, not worth > > refactoring. > > > > > > PS: Please use phabricator, we're told reviewboard is on the way out. superseeded by https://phabricator.kde.org/D9386 - Ralf ---

Re: Review Request 130228: Mingw32 compile fix

2017-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130228/#review103611 --- Ship it! Looks OK. Nice code duplication, but ok, this is

Review Request 130228: Mingw32 compile fix

2017-08-16 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130228/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript