Re: Review Request 129607: Display Application version in About dialog header

2016-12-08 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- (Updated Dec. 9, 2016, 7:08 a.m.) Status -- This change has been mar

Re: Review Request 129607: Display Application version in About dialog header

2016-12-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101330 --- Ship it! Ship It! - Sebastian Kügler On Dec. 7, 2016,

Re: Review Request 129607: Display Application version in About dialog header

2016-12-07 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- (Updated Dec. 7, 2016, 11:31 a.m.) Review request for KDE Frameworks, KDE

Re: Review Request 129607: Display Application version in About dialog header

2016-12-07 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- (Updated Dec. 7, 2016, 11:30 a.m.) Review request for KDE Frameworks, KDE

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Anthony Fieroni
> On Дек. 3, 2016, 6:48 след обяд, Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context,

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Lamarque Souza
> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but "

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Martin Klapetek
> On Dec. 3, 2016, 5:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but "

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Thomas Pfeiffer
> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe "Libraries u

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101247 --- How about "Using" for the title of the tab and then removing

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Gräßlin
> On Dec. 3, 2016, 2:29 p.m., Sebastian Kügler wrote: > > I understand the problem, but I don't like the duplication you're > > introducing with this patch: The version number is now on the screen two > > times when you open the versions tab, and also, why have a versions tab, > > when the ver

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Luigi Toscano
> On Dic. 3, 2016, 2:29 p.m., Sebastian Kügler wrote: > > I understand the problem, but I don't like the duplication you're > > introducing with this patch: The version number is now on the screen two > > times when you open the versions tab, and also, why have a versions tab, > > when the ver

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Gräßlin
> On Dec. 3, 2016, 2:29 p.m., Sebastian Kügler wrote: > > I understand the problem, but I don't like the duplication you're > > introducing with this patch: The version number is now on the screen two > > times when you open the versions tab, and also, why have a versions tab, > > when the ver

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- (Updated Dec. 3, 2016, 1:39 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- (Updated Dec. 3, 2016, 1:39 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Luigi Toscano
> On Dic. 3, 2016, 2:29 p.m., Sebastian Kügler wrote: > > I understand the problem, but I don't like the duplication you're > > introducing with this patch: The version number is now on the screen two > > times when you open the versions tab, and also, why have a versions tab, > > when the ver

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101235 --- I understand the problem, but I don't like the duplication y

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Luigi Toscano
> On Dic. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. > > Martin Gräßlin wrote: > I

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Gräßlin
> On Dec. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. > > Martin Gräßlin wrote: > I

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Gräßlin
> On Dec. 3, 2016, 1:28 p.m., Martin Gräßlin wrote: > > As the one who did the mentioned change: -1 to this > > > > Please note that this change was done in coordination with the usability > > group. So please add our usability experts to this review request. I think I should explain a little

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101229 --- As the one who did the mentioned change: -1 to this Please

Re: Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101228 --- +1, I also find the additional click annoying. Though with

Review Request 129607: Display Application version in About dialog header

2016-12-03 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/ --- Review request for KDE Frameworks. Repository: kxmlgui Description