Re: Review Request 129426: refactor gpg finding

2016-11-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/ --- (Updated Nov. 21, 2016, 8:50 a.m.) Review request for KDE Frameworks. C

Re: Review Request 129426: refactor gpg finding

2016-11-21 Thread Harald Sitter
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

2016-11-20 Thread Jan Kundrát
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

2016-11-20 Thread Harald Sitter
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Harald Sitter
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. You take

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/#review100933 --- CMakeLists.txt (line 37)

Review Request 129426: refactor gpg finding

2016-11-18 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/ --- Review request for KDE Frameworks. Repository: kwallet Description