Re: Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129248/ --- (Updated Oct. 23, 2016, 9:52 p.m.) Status -- This change has been ma

Re: Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
> On Oct. 23, 2016, 8:30 p.m., David Faure wrote: > > Seems reasonable to me, if indeed both need to be supported then I don't > > see a better way. Committed 20eac1f76ed5af9632b8da360fac2d48d6d43dfd. Sorry - forgot to amend the commit to add the REVIEW tag. - Krzysztof ---

Re: Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129248/#review100220 --- Ship it! Seems reasonable to me, if indeed both need to b

Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129248/ --- Review request for KDE Frameworks, Dawit Alemayehu and David Faure. Repos