Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-22 Thread Elvis Angelaccio
> On July 21, 2016, 10:51 p.m., Martin Klapetek wrote: > > Just a tiny note - that separator is horizontal, not vertical ;) Oh, of course ;) - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-22 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97747 --- Ship it! This is much better, thanks :) - Ragnar Thomsen

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97737 --- Just a tiny note - that separator is horizontal, not vertical

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97729 --- If there are no objections by tomorrow, I'm going to push thi

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-20 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97665 --- +1 It may still scare people, but I think it's a good comprom

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-20 Thread Olivier Churlaud
> On July 20, 2016, 3:48 p.m., Thomas Pfeiffer wrote: > > +1 > > It may still scare people, but I think it's a good compromise. If we get bad feedback , it can be reverted. But I think we won't - Olivier --- This is an automatically gen

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97664 --- Ship it! Ship It! - Olivier Churlaud On July 20, 2016,

Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-20 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/ --- Review request for KDE Frameworks and KDE Usability. Repository: kio De