Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ --- (Updated July 24, 2016, 10:07 p.m.) Status -- This change has been m

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97788 --- If there are no objections by today, I'm going to ship this.

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-22 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ --- (Updated July 22, 2016, 9:21 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-21 Thread Elvis Angelaccio
> On July 16, 2016, 10:30 a.m., Elvis Angelaccio wrote: > > Ping? > > > > (String freeze for frameworks is next Saturday, right?) > > Olivier Churlaud wrote: > I would say: replace the [copy] button by a select on click. and then > ship it Not sure about this. A button is self-explicative

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-20 Thread Olivier Churlaud
> On July 16, 2016, 12:30 p.m., Elvis Angelaccio wrote: > > Ping? > > > > (String freeze for frameworks is next Saturday, right?) I would say: replace the [copy] button by a select on click. and then ship it - Olivier --- This is an au

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-16 Thread Elvis Angelaccio
> On July 11, 2016, 9:43 a.m., Dominik Haumann wrote: > > Looks good to me. > > > > I suggest making a the calculated checksum a KSqueezedTextLabel [1], this > > way the checksum does not break the layout (in one of the animated gifs, > > the width of the dialog changes). > > [1] > > https://

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97473 --- Ping? (String freeze for frameworks is next Saturday, right?

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-11 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97287 --- Ship it! Looks good to me. I suggest making a the calcula

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-10 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97264 --- +1, makes it even easier! - Thomas Pfeiffer On July 9, 201

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-10 Thread Michel Hermier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97249 --- I don't see the point of this change. From a user perspective

Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-09 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ --- Review request for KDE Frameworks, KDE Usability and David Faure. Reposit