Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/ --- (Updated June 13, 2016, 8:11 a.m.) Status -- This change has been ma

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/#review96404 --- Ship it! Ship It! - Martin Gräßlin On June 13, 2016, 9:

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/ --- (Updated June 13, 2016, 7:57 a.m.) Review request for KDE Frameworks and

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/#review96402 --- CMakeLists.txt (line 78)

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/ --- (Updated June 13, 2016, 7:41 a.m.) Review request for KDE Frameworks and

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-13 Thread Martin Gräßlin
> On June 13, 2016, 7:39 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 76-78 > > > > > > instead of adding a definition could you make it a configure file? > > Christoph Cullmann wrote: > Sure, is tha

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Christoph Cullmann
> On June 13, 2016, 5:39 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 76-78 > > > > > > instead of adding a definition could you make it a configure file? Sure, is that the prefered way? I thought adding

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/#review96397 --- CMakeLists.txt (lines 74 - 76)

Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarat