Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-29 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/ --- (Updated March 29, 2016, 3:52 p.m.) Status -- This change has been m

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review94109 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 27, 201

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-27 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/ --- (Updated March 27, 2016, 6:21 p.m.) Review request for KDE Frameworks.

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review93956 --- Could we get a test for this? - Aleix Pol Gonzalez On Marc

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-24 Thread Dominik Haumann
> On March 24, 2016, 9:11 p.m., Dominik Haumann wrote: > > Btw: If you think QChar::isPrint() is a better choice [1], I'm happy to > > update the review request accordingly. > > > > [1] http://doc.qt.io/qt-5/qchar.html#isPrint-1 Oh, and for a correct review, the isprint() comes from https://l

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-24 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review93946 --- Btw: If you think QChar::isPrint() is a better choice [1], I'

Review Request 127488: Fix usage of std::isprint() function

2016-03-24 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/ --- Review request for KDE Frameworks. Bugs: 357341 https://bugs.kde.org/