Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/ --- (Updated March 24, 2016, 8:18 a.m.) Status -- This change has been m

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/#review93863 --- Ship it! Ship It! - David Edmundson On March 20, 2016,

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-22 Thread David Faure
> On March 21, 2016, 6:18 p.m., David Edmundson wrote: > > src/widgets/kurlcompletion.cpp, line 1445 > > > > > > this looks wrong, shouldn't it be insertItems (or ::addMatches which > > does the same thing) > >

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/#review93829 --- src/widgets/kurlcompletion.cpp (line 1362)

Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/ --- Review request for KDE Frameworks. Repository: kio Description ---