Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-11 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ --- (Updated March 11, 2016, 12:43 p.m.) Status -- This change has been

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-08 Thread Kåre Särs
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote: > > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129 > > > > > > Thanks for the comment. However, as long as we don't know the root > > cause for the null p

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-08 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/#review93309 --- Ship it! - Gregor Mi On March 7, 2016, 8:38 p.m., Kåre S

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-08 Thread Gregor Mi
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote: > > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129 > > > > > > Thanks for the comment. However, as long as we don't know the root > > cause for the null p

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Kåre Särs
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote: > > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129 > > > > > > Thanks for the comment. However, as long as we don't know the root > > cause for the null p

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/#review93270 --- src/kmoretools/kmoretoolsmenufactory.cpp (lines 128 - 129) <

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ --- (Updated March 7, 2016, 8:38 p.m.) Review request for KDE Frameworks and