Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Pinak Ahuja
> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Boudhayan Gupta
> On Feb. 26, 2016, 2:48 a.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92783 --- src/externalextractor.cpp (line 104)

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92777 --- The logic is more or less sound. You'll have to solve these i

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 25, 2016, 6:32 p.m.) Review request for Baloo, KDE Framewor