Re: Review Request 126955: Fix crash in activities context menu

2016-02-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/ --- (Updated Feb. 6, 2016, 10:03 a.m.) Status -- This change has been ma

Re: Review Request 126955: Fix crash in activities context menu

2016-02-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/#review92111 --- Ship it! Ship It! - David Faure On Feb. 6, 2016, 1:23 a

Re: Review Request 126955: Fix crash in activities context menu

2016-02-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/ --- (Updated Feb. 6, 2016, 1:23 a.m.) Review request for KDE Frameworks. Bu

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread David Faure
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new, not

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread Ivan Čukić
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new, not

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new, not

Re: Review Request 126955: Fix crash in activities context menu

2016-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/#review91918 --- Looks correct, although IMHO it's the code that creates a cla

Review Request 126955: Fix crash in activities context menu

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126955/ --- Review request for KDE Frameworks. Bugs: 351485 http://bugs.kde.org/s