Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- (Updated Feb. 2, 2016, 5:23 a.m.) Status -- This change has been mar

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/#review91941 --- Ship it! A couple of nit-picks: - kactivities reviews sh

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- (Updated Feb. 2, 2016, 12:11 p.m.) Review request for KDE Frameworks. B

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/#review91935 --- src/workspace/settings/imports/dialog.cpp (line 142)

Review Request 126945: Don't call exec() from QML

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- Review request for KDE Frameworks. Bugs: 357435 http://bugs.kde.org/s