Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-15 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/ --- (Updated Feb. 15, 2016, 7:45 p.m.) Status -- This change has been ma

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92390 --- Ship it! Yes in my opinion this is fine and in line with h

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-14 Thread Kåre Särs
> On Feb. 14, 2016, 11:11 p.m., Aleix Pol Gonzalez wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 192 > > > > > > Wouldn't it be a good practice to assume people are doing the right > > thing

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-14 Thread Kåre Särs
> On Feb. 14, 2016, 11:12 p.m., Aleix Pol Gonzalez wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 198 > > > > > > We shouldn't be calling sync API there. That is true :( I have been debuggi

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92369 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 198)

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92368 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 192)

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review92350 --- Looks good to me. Possibly switch the if/else to have the sh

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-02-13 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/ --- (Updated Feb. 14, 2016, 6:25 a.m.) Review request for KDE Frameworks, Ale

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-26 Thread Kåre Särs
> On Jan. 26, 2016, 7:31 a.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > OK then you can remove the "is that a BUG" question here. > > > > I'm still c

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91605 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195)

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread Alex Richardson
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread Kåre Särs
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread David Faure
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-24 Thread Kåre Särs
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91545 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195)

Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-24 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos