Re: Review Request 126724: Expose callingUser in HelperSupport if available

2017-02-26 Thread Martin Gräßlin
> On Feb. 25, 2017, 11:53 p.m., Albert Astals Cid wrote: > > Martin any reason this was not commmited? Should I? If I remember correctly it depends on a newer polkit-qt functionality and polkit-qt hasn't seen a release yet. Unfortunately I cannot really check as the diff now only shows whitesp

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review102607 --- Martin any reason this was not commmited? Should I? - Alber

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-13 Thread Martin Gräßlin
> On Jan. 12, 2016, 3:45 p.m., David Edmundson wrote: > > looks good, thanks for this patch. > > > > note given my comment in the other patch you'll need to change 1 line here. I have adjusted to the new code locally. As it's only a minor change I'm not going to upload again to RB. - Martin

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review90973 --- Ship it! As long as the additional dependency does not cause

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review90971 --- Ship it! looks good, thanks for this patch. note given my co

Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/ --- Review request for KDE Frameworks, Dario Freddi and David Edmundson. Repo