---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/
---
(Updated Dec. 28, 2015, 12:12 a.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/#review90161
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 26, 2015, 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/
---
(Updated Dec. 26, 2015, 5:45 a.m.)
Review request for KDE Frameworks and
> On Dec. 25, 2015, 9:14 a.m., David Faure wrote:
> > Ship It!
withdrawn, see above
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/#review90085
--
> On Dec. 25, 2015, 1:58 a.m., Aleix Pol Gonzalez wrote:
> > If making the destructor virtual doesn't break ABI, I'd vote for that...
The node classes are internal, so this wouldn't break ABI indeed.
Hmm, right, this would make "delete node" work everywhere. Michael's fix misses
the other plac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/#review90085
---
Ship it!
Ship It!
- David Faure
On Dec. 25, 2015, 12:12 a.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/#review90080
---
If making the destructor virtual doesn't break ABI, I'd vote f
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126506/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
Desc