Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-27 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/ --- (Updated Dec. 28, 2015, 12:12 a.m.) Status -- This change has been m

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90161 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 26, 2015, 6

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/ --- (Updated Dec. 26, 2015, 5:45 a.m.) Review request for KDE Frameworks and

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-25 Thread David Faure
> On Dec. 25, 2015, 9:14 a.m., David Faure wrote: > > Ship It! withdrawn, see above - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90085 --

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-25 Thread David Faure
> On Dec. 25, 2015, 1:58 a.m., Aleix Pol Gonzalez wrote: > > If making the destructor virtual doesn't break ABI, I'd vote for that... The node classes are internal, so this wouldn't break ABI indeed. Hmm, right, this would make "delete node" work everywhere. Michael's fix misses the other plac

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90085 --- Ship it! Ship It! - David Faure On Dec. 25, 2015, 12:12 a.

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90080 --- If making the destructor virtual doesn't break ABI, I'd vote f

Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

2015-12-24 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc