Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-09-21 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/ --- (Updated Sept. 21, 2016, 1:26 p.m.) Status -- This change has been m

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I re

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Aleix Pol Gonzalez
> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I reme

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I re

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Aleix Pol Gonzalez
> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` > > Ralf Habacker wrote: > If I reme

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
> On Jan. 4, 2016, 3:09 nachm., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` If I remember correctly I took it from

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/ --- (Updated Jan. 4, 2016, 2:11 p.m.) Status -- This change has been mar

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/#review90552 --- KF5CoreAddonsConfig.cmake.in (line 12)

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/#review90546 --- Ship it! I can't see anything obviously wrong with it. (But a

Review Request 126494: Add cross compile support for desktoptojson.

2015-12-23 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description