Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 15, 2016, 9:16 p.m.) Status -- This change has been ma

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 10, 2016, 11:33 p.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 80 > > > > > > this ';' seems unnecessary and weird, it's the end of an if() block. Stray junk indeed. - Thomas

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90869 --- Ship it! Ship It! - Martin Gräßlin On Jan. 10, 2016, 10:58

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90863 --- OK, I was mentionning the commit log because the one in review

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 10, 2016, 9:58 p.m.) Review request for KDE Frameworks, kwi

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 10, 2016, 9:55 a.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 61 > > > > > > How does this work? I see code iterating through that list, but I don't > > see code adding to the li

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90834 --- src/platforms/xcb/kwindowsystem.cpp (line 60)

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 6, 2016, 5:34 p.m.) Review request for KDE Frameworks, kwin

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. We're trying to re

Re: Review Request 126403: Get rid of QApplication dependency

> On gen. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? I have not, I thought you had made it clear in the past you thought it was a bad idea since it was all supposed to be widget based anyway. - Albert ---

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90522 --- anyone tested this on an "affected system"? - Martin Gräßlin

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 2, 2016, 9:57 a.m.) Review request for KDE Frameworks, kwin

Re: Review Request 126403: Get rid of QApplication dependency

> On Jan. 1, 2016, 7:47 p.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 891 > > > > > > isn't that "return displayGeometry()?" > > > > If not, then at least something like QRect(QP

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90395 --- src/platforms/xcb/kwindowsystem.cpp (line 59)

Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- Review request for KDE Frameworks, kwin and Albert Astals Cid. Bugs: 3548