Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 17:56 GMT-03:00 David Faure : > On Wednesday 25 November 2015 14:54:49 Luiz Romário Santana Rios wrote: >> > >> > My /usr/include/zconf.h says >> > >> > #if defined(ZLIB_CONST) && !defined(z_const) >> > # define z_const const >> > #else >> > # define z_const >> > #endif >> >> Mine does

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Wednesday 25 November 2015 14:54:49 Luiz Romário Santana Rios wrote: > > > > My /usr/include/zconf.h says > > > > #if defined(ZLIB_CONST) && !defined(z_const) > > # define z_const const > > #else > > # define z_const > > #endif > > Mine doesn't define anything like that. > > > > > and /usr/i

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 13:08 GMT-03:00 David Faure : > On Wednesday 25 November 2015 12:21:11 Luiz Romário Santana Rios wrote: >> >> Btw, the commit 0f0230f7d2feeca7ed00072e7b17b24c14f53698 ("Fix clang >> warnings") makes the compilation fail in my machine. In the >> KGzipFilter::setInBuffer() method, you chan

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Wednesday 25 November 2015 12:21:11 Luiz Romário Santana Rios wrote: > > Btw, the commit 0f0230f7d2feeca7ed00072e7b17b24c14f53698 ("Fix clang > warnings") makes the compilation fail in my machine. In the > KGzipFilter::setInBuffer() method, you change a C-cast to (Bytef *) to > a reinterpret_ca

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-25 5:08 GMT-03:00 David Faure : > On Tuesday 24 November 2015 23:38:28 David Faure wrote: >> On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: >> > 2015-11-21 21:02 GMT-03:00 David Faure : >> > > >> > > This is an automatically generated e-mail. To reply, visit: >> > > h

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Tuesday 24 November 2015 23:38:28 David Faure wrote: > On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: > > 2015-11-21 21:02 GMT-03:00 David Faure : > > > > > > This is an automatically generated e-mail. To reply, visit: > > > https://git.reviewboard.kde.org/r/125974/ > > >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: > 2015-11-21 21:02 GMT-03:00 David Faure : > > > > This is an automatically generated e-mail. To reply, visit: > > https://git.reviewboard.kde.org/r/125974/ > > > > On November 7th, 2015, 9:25 a.m. UTC, David Faure wrote: > > > >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-21 21:02 GMT-03:00 David Faure : > > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125974/ > > On November 7th, 2015, 9:25 a.m. UTC, David Faure wrote: > > BTW why create a KTar on top of a KCompressionDevice? KTar is able to handle > comp

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/ --- (Updated Nov. 23, 2015, 2:57 p.m.) Status -- This change has been di

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 7, 2015, 9:25 a.m., David Faure wrote: > > BTW why create a KTar on top of a KCompressionDevice? KTar is able to > > handle compression automatically all by itself... and that's exactly the > > case where it will use a tempfile for the uncompressed data, making seeking > > work. This

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 7, 2015, 9:25 a.m., David Faure wrote: > > BTW why create a KTar on top of a KCompressionDevice? KTar is able to > > handle compression automatically all by itself... and that's exactly the > > case where it will use a tempfile for the uncompressed data, making seeking > > work. This

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/#review88126 --- BTW why create a KTar on top of a KCompressionDevice? KTar is

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/#review88125 --- src/ktar.cpp (line 480)

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/#review88078 --- src/karchive.cpp (line 652)

Review Request 125974: Make KTar KCompressionDevice-friendly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125974/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kar