Re: Review Request 125965: Add declarative plugin to KHolidays

2016-03-21 Thread Martin Klapetek
> On Nov. 6, 2015, 3:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see http://woboq.com/blo

Re: Review Request 125965: Add declarative plugin to KHolidays

2016-03-20 Thread David Faure
> On Nov. 6, 2015, 2:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see http://woboq.com/blo

Re: Review Request 125965: Add declarative plugin to KHolidays

2016-03-19 Thread Martin Klapetek
> On Nov. 6, 2015, 3:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see http://woboq.com/blo

Re: Review Request 125965: Add declarative plugin to KHolidays

2016-03-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/ --- (Updated March 16, 2016, 9:24 p.m.) Status -- This change has been m

Re: Review Request 125965: Add declarative plugin to KHolidays

2016-03-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review93625 --- Ok so I shipped this because I realized KHolidays is still pa

Re: Review Request 125965: Add declarative plugin to KHolidays

2015-11-06 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review88099 --- src/declarative/holidayregionsmodel.cpp (line 81)

Re: Review Request 125965: Add declarative plugin to KHolidays

2015-11-06 Thread Aleix Pol Gonzalez
> On Nov. 6, 2015, 12:49 a.m., Aleix Pol Gonzalez wrote: > > I don't know enough about the module, so I don't know about the exact case, > > but usually it's good to develop such API outside then when it stabilizes > > merge to the framework, I'd say. Otherwise changes in the API will be very

Re: Review Request 125965: Add declarative plugin to KHolidays

2015-11-06 Thread Martin Klapetek
> On Nov. 6, 2015, 12:49 a.m., Aleix Pol Gonzalez wrote: > > I don't know enough about the module, so I don't know about the exact case, > > but usually it's good to develop such API outside then when it stabilizes > > merge to the framework, I'd say. Otherwise changes in the API will be very

Re: Review Request 125965: Add declarative plugin to KHolidays

2015-11-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review88070 --- I don't know enough about the module, so I don't know about th

Review Request 125965: Add declarative plugin to KHolidays

2015-11-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/ --- Review request for KDE Frameworks and John Layt. Repository: kholidays