Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88852 --- autotests/CMakeLists.txt (line 44)

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

> On Nov. 25, 2015, 9:30 p.m., David Faure wrote: > > autotests/CMakeLists.txt, line 44 > > > > > > sorry I just realized something else: these calls to "tar" will break > > on Windows. > > > > I would s

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88850 --- autotests/CMakeLists.txt (line 44)

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 9:19 p.m.) Status -- This change has been ma

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 9:16 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88847 --- Ship it! I would have used less member variables in the unitt

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 25, 2015, 3:12 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

> On Nov. 4, 2015, 2:11 a.m., Aleix Pol Gonzalez wrote: > > autotests/kcompressiondevicetest.cpp, line 29 > > > > > > Can't KArchive do that already? I don't believe it can. It can do the opposite -- CompressionT

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88018 --- autotests/kcompressiondevicetest.cpp (line 29)

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- (Updated Nov. 4, 2015, 9:34 p.m.) Review request for KDE Frameworks and A

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review87980 --- autotests/kcompressiondevicetest.cpp (line 29)

Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kar