Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/ --- (Updated Nov. 4, 2015, 8:47 p.m.) Status -- This change has been mar

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/#review87977 --- Ship it! Looks good to me. - Michael Pyne On Nov. 3, 2015,

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/#review87974 --- Ship it! I'm happy for this to go in - you may want to wait f

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

> On Nov. 3, 2015, 10:21 p.m., Alex Merry wrote: > > src/kdeui/kpixmapcache.cpp, line 132 > > > > > > Why time_t here, and quint32 further down? If anything, I'd expect it > > to be the other way around - this i

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

> On nov. 3, 2015, 10:21 p.m., Alex Merry wrote: > > src/kdeui/kpixmapcache.cpp, line 132 > > > > > > Why time_t here, and quint32 further down? If anything, I'd expect it > > to be the other way around - this i

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/#review87970 --- src/kdeui/kpixmapcache.cpp (line 132)

Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/ --- Review request for KDE Frameworks and Michael Pyne. Repository: kdelibs4s