Re: Review Request 125797: protocoltojson application

2015-10-27 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- (Updated Oct. 27, 2015, 4:54 p.m.) Status -- This change has been ma

Re: Review Request 125797: protocoltojson application

2015-10-27 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87527 --- Ship it! - Alex Richardson On Oct. 26, 2015, 5:03 p.m., Chr

Re: Review Request 125797: protocoltojson application

2015-10-27 Thread Christoph Cullmann
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-27 Thread Alex Richardson
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread David Faure
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure whethe

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87444 --- The protocoltojson program will have to read the plugin metada

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread David Faure
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- (Updated Oct. 26, 2015, 4:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Alex Richardson
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Alex Merry
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Christoph Cullmann
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125797: protocoltojson application

2015-10-26 Thread Alex Merry
> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. How about "KDE-KIO-Protocols"? I think having a KDE pre

Re: Review Request 125797: protocoltojson application

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87382 --- I think one needs to add a outer scope with some "KIO-Protocol

Review Request 125797: protocoltojson application

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc