Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated March 28, 2016, 4:14 p.m.) Status -- This change has been m

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

> On March 26, 2016, 3:23 p.m., David Faure wrote: > > Looks good to me, although this could all be a single perl script instead > > of a bash script calling perl so many times ;) But that's unrelated to this > > commit. > > > > Also in its current form, it should be a .sh rather than a .pl ..

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

> On March 26, 2016, 3:23 p.m., David Faure wrote: > > Looks good to me, although this could all be a single perl script instead > > of a bash script calling perl so many times ;) But that's unrelated to this > > commit. > > > > Also in its current form, it should be a .sh rather than a .pl ..

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review94011 --- Ship it! Looks good to me, although this could all be a si

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated March 26, 2016, 12:31 p.m.) Review request for KDE Frameworks, K

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review94004 --- The reviewboard upgrade must have messed up something, the cu

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review93976 --- Well, this hasn't been resolved for a while now. A final ping

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review87193 --- Ping ? - R.Harish Navnit On Oct. 12, 2015, 12:24 a.m., R.H

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated Oct. 12, 2015, 12:24 a.m.) Review request for KDE Frameworks and

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

> On Oct. 9, 2015, 5:51 p.m., Daniel Vrátil wrote: > > kf5/convert-kabc-to-kcontacts.pl, line 6 > > > > > > you could use `$gi` at the end to make the match case-insensitive, thus > > saving one regexp per each fi

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

> On Oct. 9, 2015, 2:21 p.m., Daniel Vrátil wrote: > > kf5/convert-kabc-to-kcontacts.pl, line 78 > > > > > > This will still break build (as expected): > > > > `KABC::Addressbook a()` -> `a()`. >

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review86546 --- kf5/convert-kabc-to-kcontacts.pl (line 6)

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated Oct. 9, 2015, 5:39 p.m.) Review request for KDE Frameworks and K