Re: Review Request 125556: Install CamelCase headers

2015-10-17 Thread David Faure
> On Oct. 11, 2015, 9:03 p.m., David Faure wrote: > > src/CMakeLists.txt, line 24 > > > > > > Well, then the lib itself shouldn't be called KF5MediaWiki? > > > > But of course changing this is only possib

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
> On Oct. 12, 2015, 12:03 a.m., David Faure wrote: > > src/CMakeLists.txt, line 24 > > > > > > Well, then the lib itself shouldn't be called KF5MediaWiki? > > > > But of course changing this is only possi

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86673 --- This fix looks good to me, but I see an inconsistency overall:

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
> On Oct. 11, 2015, 2:02 p.m., Alexander Potashev wrote: > > libmediawiki is not part of KF5, I would avoid installing into > > /usr/include/KF5 to prevent possible collision in the future. ok, like this? but it also installs KF5/mediawiki_version.h that's from main CMakeLists.txt - Dāvis

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/ --- (Updated Oct. 11, 2015, 10:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86657 --- libmediawiki is not part of KF5, I would avoid installing into

Re: Review Request 125556: Install CamelCase headers

2015-10-10 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/ --- (Updated Oct. 11, 2015, 2:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 125556: Install CamelCase headers

2015-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86634 --- src/CMakeLists.txt (line 80)

Review Request 125556: Install CamelCase headers

2015-10-08 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/ --- Review request for KDE Frameworks and Adrián Chaves Fernández. Repository