Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 12, 2015, 11:36 matin) Status -- This change has been

Re: Review Request 125514: Add a web shortcut manager

> On oct. 12, 2015, 7:02 matin, David Faure wrote: > > autotests/kurifiltersearchprovideractionstest.cpp, line 51 > > > > > > Well, KIO itself installs a large number of search providers, so this > > unittest can

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 --- Ship it! autotests/kurifiltersearchprovideractionstest.cpp (

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86688 --- Ping ?:) - Laurent Montel On oct. 10, 2015, 12:56 après-mid

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 10, 2015, 12:56 après-midi) Review request for KDE Framewor

Re: Review Request 125514: Add a web shortcut manager

> On oct. 7, 2015, 5:27 matin, Laurent Montel wrote: > > What about rename class ? No news so I will rename it to KUriFilterSearchProviderActions - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.revi

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86442 --- What about rename class ? - Laurent Montel On oct. 4, 2015,

Re: Review Request 125514: Add a web shortcut manager

> On oct. 5, 2015, 2:01 après-midi, Eike Hein wrote: > > Comparing this to the implementation in Konversation/Konsole/Okular might > > be interesting. I looked code and it's similar. Do you have more info about it ? (missing feature from this widget etc ?) - Laurent

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86373 --- Comparing this to the implementation in Konversation/Konsole/O

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 4, 2015, 2:04 après-midi) Review request for KDE Frameworks

Re: Review Request 125514: Add a web shortcut manager

> On oct. 4, 2015, 11:52 matin, David Faure wrote: > > Seems useful to have, I've seen such actions in multiple places, including > > KHTML and KWebkit (and I know you're coming from kdepim with this). > > > > I'm wondering if the naming couldn't be improved though. This has very > > little to

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86327 --- Seems useful to have, I've seen such actions in multiple place

Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc