Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/ --- (Updated Sept. 29, 2015, 9:21 p.m.) Status -- This change has been m

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review86093 --- Ship it! Ship It! - Martin Gräßlin On Sept. 28, 2015, 5:45

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/ --- (Updated Sept. 28, 2015, 3:45 nachm.) Review request for KDE Frameworks a

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Thomas Lübking
> On Sept. 28, 2015, 12:56 nachm., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > > > > > I don't like the type name "Atom" as that's also an XLib type. As the > > actual name is hardly used w

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Martin Gräßlin
> On Sept. 28, 2015, 2:56 p.m., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > > > > > I don't like the type name "Atom" as that's also an XLib type. As the > > actual name is hardly used we c

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Thomas Lübking
> On Sept. 28, 2015, 12:56 nachm., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > > > > > I don't like the type name "Atom" as that's also an XLib type. As the > > actual name is hardly used w

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review86036 --- hard cost. I now understand why I didn't get what you meant in

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-19 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review85666 --- src/platforms/xcb/atoms_p.h (line 25)

Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-19 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow