Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
> On Aug. 24, 2015, 11:18 p.m., Alex Richardson wrote: > > src/core/slave.cpp, line 89 > > > > > > Unrelated but while you're touching this code maybe change this to > > qEnvironmentVariableIsSet(). More efficien

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- (Updated Aug. 25, 2015, 7:10 a.m.) Status -- This change has been ma

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84318 --- Ship it! Ship It! - David Faure On Aug. 24, 2015, 1:11 p.m

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84309 --- Looks good to me src/core/slave.cpp (line 88)

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- (Updated Aug. 24, 2015, 1:11 p.m.) Review request for KDE Frameworks, Dav

Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- Review request for KDE Frameworks, David Faure and Boudewijn Rempt. Repos