Re: Review Request 124105: Adhere a bit better to the spec

2015-08-16 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- (Updated Aug. 16, 2015, 1:14 p.m.) Status -- This change has been ma

Re: Review Request 124105: Adhere a bit better to the spec

2015-07-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review82468 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 4, 2015, 9:

Re: Review Request 124105: Adhere a bit better to the spec

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review82115 --- +1 LGTM. - Aleix Pol Gonzalez On July 4, 2015, 9:18 p.m., S

Re: Review Request 124105: Adhere a bit better to the spec

2015-06-15 Thread Sune Vuorela
> On June 15, 2015, 11:38 p.m., Christoph Feck wrote: > > Could you please describe (or code) a test case? Or point to a bug report? It was things I stumbled upon while working on https://bugs.kde.org/show_bug.cgi?id=344469 - but unit test attached now. - Sune --

Re: Review Request 124105: Adhere a bit better to the spec

2015-06-15 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- (Updated June 16, 2015, 5:59 a.m.) Review request for KDE Frameworks, Dav

Re: Review Request 124105: Adhere a bit better to the spec

2015-06-15 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81499 --- Could you please describe (or code) a test case? Or point to a

Re: Review Request 124105: Adhere a bit better to the spec

2015-06-15 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81498 --- src/kicontheme.cpp (line 664)

Review Request 124105: Adhere a bit better to the spec

2015-06-15 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/ --- Review request for KDE Frameworks, David Faure and Martin Klapetek. Repos