Re: Review Request 124089: Connected timeout before timer start.

2017-01-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review102141 --- I'm going to discard this as it seems that Jordan Hewitt did

Re: Review Request 124089: Connected timeout before timer start.

2017-01-20 Thread Jordan Hewitt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated Jan. 21, 2017, 12:53 a.m.) Status -- This change has been d

Re: Review Request 124089: Connected timeout before timer start.

2015-06-15 Thread David Faure
> On June 13, 2015, 7:28 p.m., David Faure wrote: > > startTimer is called many times so doing the connect every time is wrong, > > and the connect is already done before, so I don't understand this patch. > > What problem is it supposed to fix? > > Jordan He wrote: > I was having an issue

Re: Review Request 124089: Connected timeout before timer start.

2015-06-15 Thread Jordan He
> On June 13, 2015, 7:28 p.m., David Faure wrote: > > startTimer is called many times so doing the connect every time is wrong, > > and the connect is already done before, so I don't understand this patch. > > What problem is it supposed to fix? I was having an issue with Konsole on Plasma 5 (K

Re: Review Request 124089: Connected timeout before timer start.

2015-06-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81450 --- startTimer is called many times so doing the connect every tim

Re: Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81433 --- src/widgets/krun.cpp (line 859)

Re: Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81429 --- src/widgets/krun.cpp (line 99)

Re: Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread Jordan He
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review81427 --- Ship it! Ship It! - Jordan He On June 12, 2015, 8:27 p.m.,

Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread Jordan He
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- Review request for KDE Frameworks. Repository: kio Description ---