Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- (Updated June 1, 2015, 1:22 p.m.) Status -- This change has been mar

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/#review81049 --- Ship it! Ship It! - David Edmundson On June 1, 2015, 12:49

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- (Updated June 1, 2015, 2:49 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread Martin Klapetek
> On June 1, 2015, 2:40 p.m., David Edmundson wrote: > > src/notifybyexecute.cpp, line 56 > > > > > > should this have an > > > > else subst.insert("w", 0); ? > > > > otherwise it won't be subst

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/#review81044 --- src/notifybyexecute.cpp (line 54)

Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

2015-06-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- Review request for KDE Frameworks. Bugs: 348510 https://bugs.kde.org/